From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3487397AAE for ; Wed, 14 Jan 2026 13:40:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768398006; cv=none; b=X4uac+r25zQfObIidew8e6k3jiCLEEE3Y+72D5/KyFQqY7H8Snjyp//pYqEzlICz/WXzirHN0z0CCRlhDsoF32F8jgmpF4gIAkB8ZOLzorMKYN4zykSpFQK8nopoFYhUfpt4N3hWiPVnSQrYOUm9lTDn64iAPgvWbddxUdgHVgg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768398006; c=relaxed/simple; bh=YZcrqwDuRyJBCAtxjucK7ekrSuDX8AnZLVJWFUZ9Q/c=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=elvKKfUD/VF2gnhmeQFMB/8X/70QZycgOesUtvfRF28eT4wgOYYJ3E4tymuwMTwFjA3RaXCF7TdPZkmMc4fvjr9nLh3sQm+FEuxjElBTw2rrpWjVmt023+29AjqVA3xDpCucc/PSA/TE643gQ8PWM+YLBuGEekODM5E5lLJfWyE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KkflNX2D; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KkflNX2D" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-4327555464cso5205689f8f.1 for ; Wed, 14 Jan 2026 05:40:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768398001; x=1769002801; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=5wmwTmp5IFzHOcZYUSrwZ2WCFgEOIoQQbhD/zBC9MXc=; b=KkflNX2D5ruSW6Mspj8bBAd1CXKfQbo0aUMc/xwUqshFuXCRe6pddzddJ06e63Kvea KxnZG/2yR1NJtjT1upohFUYOqeomQwUuu68nuYnq6nUNiggapsFn2U6tKGEnFu2dNlc9 QYyU3uh4cef/cQh2Wq6XnTUPn+4vt8wFPACNm2qMSWH+GdICN285sAOjU50WW6Ibzogz 9JVaf3eAQAYYs5hyrHoI+wyiTEgN8pY1vAgRdZN3+Dyn5dA+XPzA114LUclHTVrkSpuD smHwoHBfJ6omq2K5p9ZWOgI2G8M8bhhnRWWr5KGXMJMNENGG+Srto+BRO6DaVIWVWzwX YYRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768398001; x=1769002801; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=5wmwTmp5IFzHOcZYUSrwZ2WCFgEOIoQQbhD/zBC9MXc=; b=xQQfu2UXuxFafJy31NHT1brf80nbnaYG2do14J/07tuF5YI+2oF897wlLEFiOnNCTG 1NJRhxuGnaONGpk2r9d6N3InOnjWnvfVlepvC/58t6lA3OIvqNfmnW7s3aq/UtzeeJRD VRJqGnDVgjqUeceOpZEdh9bjPExmVFptgAvxQvDpmemjVhNccH0LjP44YAr6BEiu3i53 kzlqEzDm/I76TKxLStFdgjBwaEh5uHsYAA6C+rJzGUyA6UbymcO6cNwP3uGCH5Xihg/X WwBzcAieODFczs7C57b2a4MUywJLF9C31Pkaijzpr9ycBwwbEV+FTxQxJ32cmye+EmkM 88bA== X-Forwarded-Encrypted: i=1; AJvYcCVom53hiMEsoLCIaKbHdUMxWHOTZb7Lk90ILSKWEyXK0sajOJLj0xUOncHvh7jvGixxcHh2@lists.linux.dev X-Gm-Message-State: AOJu0Yy+/2Dq5/PrtVzH03+bJXwP1qkB6zFopz3m+iYZE0zsHBnfljzQ lr1G0KPyHIdMjUxOyVX7CVKTy+JcGOxAnqxKhdOyV74iI7Fs8+ZqxjDN X-Gm-Gg: AY/fxX5JZRmRSux4lkHoQFSnLFWKKx+8T3iBz9tBPlZdDt5+k9rWsARnfYQq9KsEdZO zvCdXsyXPsnFnMC2utbx5CSXRET5QnsLAfD3vE6HZ5Tk5vUZs3hO+ef+bcjAawScxKxOBgRfpvP M7Ona+p4BiQ9yKUzp16JORmgLNStprmYwxcuzQuR0J4xpQOg+zun78pVXv2ImFAe8gcPm77dwmx jQ4VVhxl28tJ99yNoSKPLjB0oQwGw1bX8IdsM9BsxuKEK98gO+GbdEZkU9BcpPDSl2YhBsS1wWs 5oGAo8S84AEn449Ia1NUiMyCerenxsOTKbBwbsLrAk9zFoXxkOKmCc3YVhtiQwXGAzNLaANjEYG y9u4hsUUmD+43PbGbq1Rc6dqbo0MThCIs7Dmx57ntxp5wkQy0iMsz0fBPIPtwR8yxRFErKXlJ67 F24fOCEge72xFaw3HhiAPe1j74BO5BiRoTGTL33JEWksXL1/r72brf X-Received: by 2002:a5d:53c9:0:b0:432:5bf9:cf2e with SMTP id ffacd0b85a97d-4342c3ef274mr2643750f8f.13.1768398001040; Wed, 14 Jan 2026 05:40:01 -0800 (PST) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd5edd51sm50238105f8f.29.2026.01.14.05.39.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jan 2026 05:40:00 -0800 (PST) Date: Wed, 14 Jan 2026 13:39:55 +0000 From: David Laight To: Amir Goldstein Cc: Christoph Hellwig , Jeff Layton , Christian Brauner , Chuck Lever , Jan Kara , Luis de Bethencourt , Salah Triki , Nicolas Pitre , Anders Larsen , Alexander Viro , David Sterba , Chris Mason , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Sandeep Dhavale , Hongbo Li , Chunhai Guo , Jan Kara , "Theodore Ts'o" , Andreas Dilger , Jaegeuk Kim , OGAWA Hirofumi , David Woodhouse , Richard Weinberger , Dave Kleikamp , Ryusuke Konishi , Viacheslav Dubeyko , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Mike Marshall , Martin Brandenburg , Miklos Szeredi , Phillip Lougher , Carlos Maiolino , Hugh Dickins , Baolin Wang , Andrew Morton , Namjae Jeon , Sungjong Seo , Yuezhang Mo , Alexander Aring , Andreas Gruenbacher , Jonathan Corbet , "Matthew Wilcox (Oracle)" , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , Xiubo Li , Ilya Dryomov , Trond Myklebust , Anna Schumaker , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Bharath SM , Hans de Goede , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mtd@lists.infradead.org, jfs-discussion@lists.sourceforge.net, linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, devel@lists.orangefs.org, linux-unionfs@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, gfs2@lists.linux.dev, linux-doc@vger.kernel.org, v9fs@lists.linux.dev, ceph-devel@vger.kernel.org, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org Subject: Re: [PATCH 00/24] vfs: require filesystems to explicitly opt-in to lease support Message-ID: <20260114133955.0a9f5cd3@pumpkin> In-Reply-To: References: <20260108-setlease-6-20-v1-0-ea4dec9b67fa@kernel.org> <8af369636c32b868f83669c49aea708ca3b894ac.camel@kernel.org> <20260113-mondlicht-raven-82fc4eb70e9d@brauner> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: gfs2@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Wed, 14 Jan 2026 10:34:04 +0100 Amir Goldstein wrote: > On Wed, Jan 14, 2026 at 7:28=E2=80=AFAM Christoph Hellwig wrote: > > > > On Tue, Jan 13, 2026 at 12:06:42PM -0500, Jeff Layton wrote: =20 > > > Fair point, but it's not that hard to conceive of a situation where > > > someone inadvertantly exports cgroupfs or some similar filesystem: =20 > > > > Sure. But how is this worse than accidentally exporting private data > > or any other misconfiguration? > > =20 >=20 > My POV is that it is less about security (as your question implies), and > more about correctness. >=20 > The special thing about NFS export, as opposed to, say, ksmbd, is > open by file handle, IOW, the export_operations. >=20 > I perceive this as a very strange and undesired situation when NFS > file handles do not behave as persistent file handles. >=20 > FUSE will gladly open a completely different object, sometimes > a different object type from an NFS client request after server restart. >=20 > I suppose that the same could happen with tmpfs and probably some > other fs. ... You really shouldn't be allowed to nfs export a fs that doesn't have persistent file handles. Even file handles containing 'random' numbers can be problematic. The default used to be 'hard mounts' (not sure it is any more) which caused the client (not Linux - too long ago) to loop in kernel forever waiting for the server to recover the filesystem export. The only resolution on that system was to reboot the client. At least nfs can now use variable size file-ids. When I was fixing some code that exported a layered fs (I pretty much rewrote the fs at the same time) I did randomise the file-ids so they (hopefully) became invalid after a reboot (only after suffering some very corrupt filesystems!) I found nfs (over udp) had some interesting 'features': - If you export part of a fs you export all of it. (Especially since this predated the randomisation of the inode generation number.) - If you give anyone access you give everyone access. - If you give anyone write access you give everyone write access. The latter two because the 'mount' protocol wasn't really needed and the server didn't care where requests came from. David