From: Karl Mehltretter <kmehltretter@gmail.com>
To: Andreas Gruenbacher <agruenba@redhat.com>
Cc: Karl Mehltretter <kmehltretter@gmail.com>,
Al Viro <viro@zeniv.linux.org.uk>,
gfs2@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH] gfs2: Fix the return value in gfs2_get_link() kernel-doc
Date: Sat, 12 Sep 2026 08:26:14 +0200 [thread overview]
Message-ID: <20260912062614.42899-1-kmehltretter@gmail.com> (raw)
gfs2_get_link() returns the link target or an error pointer, but its
kernel-doc still describes an integer status. The mismatch dates back to
the change in its predecessor's follow_link calling convention.
Describe the returned pointer and error value.
Fixes: 680baacbca69 ("new ->follow_link() and ->put_link() calling conventions")
Assisted-by: LLM
Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
---
fs/gfs2/inode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c
index f361876c5583353a1196ed35be1c95af33a90c02..d5e03ec89127254654dceaff56322ed617a3400a 100644
--- a/fs/gfs2/inode.c
+++ b/fs/gfs2/inode.c
@@ -1900,7 +1900,7 @@ static int gfs2_rename2(struct mnt_idmap *idmap, struct inode *odir,
*
* This can handle symlinks of any size.
*
- * Returns: 0 on success or error code
+ * Returns: the link target on success, an ERR_PTR() on failure
*/
static const char *gfs2_get_link(struct dentry *dentry,
--
2.39.5 (Apple Git-154)
next reply other threads:[~2026-09-12 6:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-12 6:26 Karl Mehltretter [this message]
2026-09-12 13:41 ` [PATCH] gfs2: Fix the return value in gfs2_get_link() kernel-doc Andreas Gruenbacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260912062614.42899-1-kmehltretter@gmail.com \
--to=kmehltretter@gmail.com \
--cc=agruenba@redhat.com \
--cc=gfs2@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox