From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=74.125.82.199 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793140767; b=oSxjE5jtyhW9dH/PGPyEhRvxzCBzvipbIxZidYlWw8mL8mHCrY9PwWhlsFDMfdxhIdGq Dtd7OxeBiHt3PtOL28p/td9MXFyu15QCwKWNCNQpiVbQUyUgsHvRMbjBcT3TPBM7B2rzE fMgfESTjOeLhJrVfRu904C5anUqMtY8FIWCC8KNeO6sw0AwAgKmiZNxAaVoZhAwYfpyCt I2wAYoStcWLAZwkSnBJ2Th7EDS4umdWIhr4n2qp2LmWoqUm0IdkZLLPi6wtZ0sWTZ0KUk wLkgjRQSMQWD76Pec5Oyi94pqzh2/X8ZXmDbdwZj5E79ecyHxhp2g4cPXLP//PtfaSQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793140767; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Received:Date:In-Reply-To: Mime-Version:References:X-Mailer:Message-ID:Subject:From:To:Cc: Content-Type; bh=dWBu3E1+9O630leKOxiPf33Qem+izCRkowC6gFS9sVM=; b=xPIFnzBU7m6kaj+WJ4mc83YexXbVzNtlumPy55dYVcnE4OMKaAbHnaHAu+qCC8Pab3NQ pGWu08YzcuiYrSzX+vdP1KkE2rO1oj3PXXe8agp3nlxzz9ypnoUst+K8G+YOlJNPsyNqB iS5WuLiiOeVy+Gd8NwSZ/7ZvNOEqWMxMyV7yqyUhtYGeLxvfuxcgwnHCw2l77sVZ6sRjB MU7yWnRiJIS2Qy4Nmt9fdoLVdLfOnjlFrKW0wOFQjtHgypaclSbqL5RodeNqVpMl2i1dB KnW/kgyq6MtdmgMIbboT3K3KJff+nCn31Dhvt9vSUVqUgIjuYNm9zIYssUDcTi+8zaw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=DGsErgmH; arc=none smtp.remote-ip=74.125.82.199 Received: from mail-dy1-f199.google.com (mail-dy1-f199.google.com [74.125.82.199]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 747A4606A33D for ; Tue, 27 Oct 2026 22:39:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 747A4606A33D Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=DGsErgmH Received: by mail-dy1-f199.google.com with SMTP id 5a478bee46e88-30bcb065bfdso523843eec.0 for ; Tue, 27 Oct 2026 15:39:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20260707; t=1793140753; x=1793745553; darn=lists.linux.dev; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=dWBu3E1+9O630leKOxiPf33Qem+izCRkowC6gFS9sVM=; b=DGsErgmHItp6/S3AaBT8V8olCPCPER+Z7wrjovO4yH1n3/74jwioz8GM9AtWdlORk3 VsOF3/5bcIXjGa3F9LEeq9WG4hOvsB3MzAllSte3w+TOqdljEWZe0eF7In6dKEW+aMUo KG1uineb6QKxXbuX0ube+z9WYEo+E25qASn3a1tWbQGnau09sUw6dINUcVvjfnw9sxo4 1yBdFkc3o1P5lumHCvCySKTND1cHg38K/kL7aIEFKVM9kYEjJkeJH/jNgBvVA8aCKJHD nIT8km0nF2h4SX7RZO3cQ3lFsuMhaQ/301spKuOhStxGKpWfNl5hGahjvQGZtb7hzf/B T2NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793140753; x=1793745553; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=dWBu3E1+9O630leKOxiPf33Qem+izCRkowC6gFS9sVM=; b=wfOXgtH/kzjxAbcZdL11LqSLxohBsmT3O+xKxmhQg4x7yBIn8OgFDJAbt3CySnzfJa HhuHKtIJkGjbaABI2nYWkzAyLxZ2Gr4GOBLgQprFgGSckhhV7TW3JCNLwGwEwS0Nztgk Chxld/ZDTAz/1y1YlKzb76PuaqIxSsyCLs8BhHYPGEkNhT64lw+XhdjwonAZrrypR+SK 5EmI6KKbsysBf4ZrErFaA6TeGnv8V1S1DUj6z4B7fy4TS0XQrC6lJXeM6F1ktzfEBSFf G5SzPuvZAZSGaAcHRsL8Y1CMpoFi2n82c9L/fVq+8NnSLULUzFp1wkmJdwAbksWfyXZK Ka+w== X-Forwarded-Encrypted: i=1; AKwUvBwT+buKMoL2KO9tIjxdrvfelX6TiNGK4HT2Zh9iGEY2URwXuwcJw72YeqvUsoMgjX7493vk@lists.linux.dev X-Gm-Message-State: AFq9FYKpwh6ArGozSywtMN3C+x1rX9AYuJ6Z0HyldeProGsAY5dC7L6Q OiXRh4jGy5PAPvEgOT8zcJ4II3+wUOqZanqDjIeuMlNsRLXaIebLO5uxd9k2SOO58gxR9/DHppg QRQEcm24cuQ== X-Received: from dybnl11.prod.google.com ([2002:a05:7300:cf8b:b0:36a:117:523b]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:693c:250d:b0:369:f5f6:36a7 with SMTP id 5a478bee46e88-36a2014b887mr1132027eec.16.1793140751881; Tue, 27 Oct 2026 15:39:11 -0700 (PDT) Date: Tue, 27 Oct 2026 15:38:36 -0700 In-Reply-To: <20261027223847.652884-1-irogers@google.com> X-Mailing-List: gfs2@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 References: <20261027223847.652884-1-irogers@google.com> X-Mailer: git-send-email 2.56.0.313.g2479322e68-goog Message-ID: <20261027223847.652884-2-irogers@google.com> Subject: [PATCH v2 1/9] Compiler Attributes: Add __must_init macro From: Ian Rogers To: Kees Cook , Greg Kroah-Hartman , Miguel Ojeda , "Rafael J . Wysocki" , Danilo Krummrich Cc: Nathan Chancellor , Nick Desaulniers , Miguel Ojeda , "=?UTF-8?q?Christian=20K=C3=B6nig?=" , Zhihao Cheng , Zhongqiu Han , Sumanth Korikkar , Bill Wendling , Justin Stitt , driver-core@lists.linux.dev, llvm@lists.linux.dev, linux-hardening@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, linux-s390@vger.kernel.org, gfs2@lists.linux.dev, xen-devel@lists.xenproject.org, linux-mtd@lists.infradead.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Ian Rogers , Jonathan Corbet , Shuah Khan , Randy Dunlap , Andy Whitcroft , Joe Perches Content-Type: text/plain; charset="UTF-8" Clang supports the 'require_explicit_initialization' attribute on struct fields to indicate that a field must be initialized explicitly by the user when the object is constructed. When an aggregate initializer or uninitialized variable omits an annotated field, Clang emits a -Wuninitialized-explicit-init warning (enabled by default). Add the __must_init macro to include/linux/compiler_attributes.h (which is included by include/linux/compiler_types.h and include/linux/compiler.h) so kernel structs with error-prone initialization (such as mandatory callbacks or cleanup handlers) can enforce explicit initialization at compile time, as discussed at the Linux Plumbers Conference. The shorter __must_init spelling, rather than the attribute's full name, keeps annotated struct members readable and was suggested by Greg Kroah-Hartman. Note that Clang does not yet diagnose file-scope objects declared without any initializer (initializers at file scope that omit the field are diagnosed), see https://github.com/llvm/llvm-project/issues/232483. Also teach Sphinx (Documentation/conf.py), kernel-doc (tools/lib/python/kdoc/xforms_lists.py), and checkpatch.pl about the new attribute macro. Link: https://lpc.events/event/20/contributions/2392/ Link: https://lore.kernel.org/lkml/2026101532-fantastic-deafness-e04c@gregkh/ Acked-by: Miguel Ojeda Reviewed-by: Nick Desaulniers Reviewed-by: Nathan Chancellor Acked-by: Greg Kroah-Hartman Signed-off-by: Ian Rogers --- Documentation/conf.py | 1 + include/linux/compiler_attributes.h | 12 ++++++++++++ scripts/checkpatch.pl | 1 + tools/lib/python/kdoc/xforms_lists.py | 1 + 4 files changed, 15 insertions(+) diff --git a/Documentation/conf.py b/Documentation/conf.py index 5ab26ce89daf..baaa4035258c 100644 --- a/Documentation/conf.py +++ b/Documentation/conf.py @@ -203,6 +203,7 @@ c_id_attributes = [ "__noreturn", "__packed", "__pure", + "__must_init", "__section", "__always_unused", "__maybe_unused", diff --git a/include/linux/compiler_attributes.h b/include/linux/compiler_attributes.h index 476c4c560d17..b9c0b56dd22e 100644 --- a/include/linux/compiler_attributes.h +++ b/include/linux/compiler_attributes.h @@ -322,6 +322,18 @@ */ #define __pure __attribute__((__pure__)) +/* + * Optional: not supported by gcc + * Optional: only supported since clang >= 20.0 + * + * clang: https://clang.llvm.org/docs/AttributeReference.html#require-explicit-initialization + */ +#if __has_attribute(__require_explicit_initialization__) +# define __must_init __attribute__((__require_explicit_initialization__)) +#else +# define __must_init +#endif + /* * gcc: https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html#index-section-function-attribute * gcc: https://gcc.gnu.org/onlinedocs/gcc/Common-Variable-Attributes.html#index-section-variable-attribute diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index c9840f5219c2..5232f66d2b80 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -6860,6 +6860,7 @@ sub process { "noreturn" => "__noreturn", "packed" => "__packed", "pure" => "__pure", + "require_explicit_initialization" => "__must_init", "section" => "__section", "used" => "__used", "weak" => "__weak" diff --git a/tools/lib/python/kdoc/xforms_lists.py b/tools/lib/python/kdoc/xforms_lists.py index 320f977c5bac..3c744cbd2f34 100644 --- a/tools/lib/python/kdoc/xforms_lists.py +++ b/tools/lib/python/kdoc/xforms_lists.py @@ -36,6 +36,7 @@ class CTransforms: (CMatch("CRYPTO_MINALIGN_ATTR"), ""), (CMatch("__private"), ""), (CMatch("__rcu"), ""), + (CMatch("__must_init"), ""), (CMatch("____cacheline_aligned_in_smp"), ""), (CMatch("____cacheline_aligned"), ""), (CMatch("__cacheline_group_(?:begin|end)"), ""), -- 2.56.0.313.g2479322e68-goog