Re: [PATCH 16/17] zonefs: use bdev_rw_virt in zonefs_read_super

Johannes Thumshirn
2025-04-29T11:44:42Z

On 22.04.25 16:31, Christoph Hellwig wrote:
> + super = kmalloc(PAGE_SIZE, GFP_KERNEL);
> + if (!super)

[...]

> + ret = bdev_rw_virt(sb->s_bdev, 0, super, PAGE_SIZE, REQ_OP_READ);

Can we change these two PAGE_SIZE into ZONEFS_SUPER_SIZE which is
semantically more correct?

Other than that,
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>