Re: [PATCH] dlm_controld: Support for extended value of kernel DLM_MAX_ADDR_COUNT

[Heming Zhao <heming.zhao@suse.com>]

Hello Dave,

On 2/25/25 14:27, Heming Zhao wrote:
> On 2/25/25 03:35, David Teigland wrote:
>> On Mon, Feb 24, 2025 at 10:27:04AM -0500, Alexander Aring wrote:
>>> What are we doing with the detect_protocol() change? You want to
>>> submit the current version again? I would like to test it with
>>> corosync 2 vs 3 with no configuration changes on an upgrade (if this
>>> is even possible).
>>
>> I suggest we stop trying to detect, and always use tcp unless protocol is
>> set to sctp.
>>
>> Dave
>>
> 
> That's fine with me
> For corosync 3.x, there is a lot of work to support dynamic multi-link.
> However, to support config mode, the current dlm code only requires a few modifications.
> 
> - Heming

Following your idea, if TCP is used by default, what will happen when a user
sets up multiple links in Corosync 3.x without changing config file?
The TCP mode of the current DLM only accepts one link. Therefore, in this
scenario, DLM will refuse to run and report an error.

Do you think we need to invest effort in changing the TCP mode code to allow
TCP to work when the Corosync layer sets up multiple links?
For example, to simplify the code, we could take only the first network link
from the Corosync callback and ignore the others. Or we could keep the current
behavior and prevent running in multi-link mode under TCP.

- Heming