Re: [PATCH v2 05/16] iomap: propagate iomap_read_folio() error to caller

Christoph Hellwig
2025-09-15T16:05:20Z

On Fri, Sep 12, 2025 at 12:28:02PM -0400, Joanne Koong wrote:
> I'll drop this. I interpreted Matthew's comment to mean the error
> return isn't useful for ->readahead but is for ->read_folio.
>
> If iomap_read_folio() doesn't do error returns and always just returns
> 0, then maybe we should just make it `void iomap_read_folio(...)`
> instead of `int iomap_read_folio(...)` then.

Yes, more void returns also really help to simplify the code flow.