From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E18B8374D9 for ; Thu, 28 Sep 2023 15:48:41 +0000 (UTC) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id A3A69581DA3; Thu, 28 Sep 2023 11:48:40 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Thu, 28 Sep 2023 11:48:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1695916120; x=1695923320; bh=AE M/fDbI9O0BImAELzI+hfXsnObtdXB3nh8ZZCXXqn0=; b=byfYA1BNqc0YjQaASF s1x85iwtpsSetZH3v6T9P24VWHjtY/C2Cy0QBMN4anJkKAx/kEgik+7dgqX7WnUW La20mPl+Hw/VFhfjU9nQv4lI54y8w78+xdi3Se04xsEpK/yzVwzapQ8MJ/9B+Ktm JGLFbhwJ3F2I83/vnqG03iBpb0Id/foHd3DxxbBNAGkh1TS6cGFhv+xeNe2uxiVA 1qtNw6fHsIlObgAbEcnfTbzpUBh/2qzRYo6CGPfmvxiTxQpNbUl8G4oC5H5iQo6x /sAEGT5XCYLJOHsqcHS9JN3fpYg+L/x6M1JiQIXk5Xp17LZq0Ehr9oFjxCiH0gfw Y0hA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1695916120; x=1695923320; bh=AEM/fDbI9O0BI mAELzI+hfXsnObtdXB3nh8ZZCXXqn0=; b=bns6ZXaqrL/zYhXfQpEqgZrIk4z8L 5qkMm8nanaHWiR3fzY/YJIDw4+d+6MfDnms8OZzMVU59EJQIob9K7kzc0B41836P pck63XByx3cERUFTmSSiKbBu5nhvH0jdl6mRd7HtSMoowPAFE7LbFjRy0HUXas/x zuZT/GjF5UmuSTx2Ncvja7fvvyhqK+7Jsd6ADNqIQbbTEHNte96FH8xT2LEQEdZk 2T5+RXWDET2gc7L+8jx1gAormT1mlAdY8znZETSBE9x8HVOf/9oCuP13d29xSJA9 mCd1merIfP+8lGUSyKAU/ig1OvFVLDfli/gPb0lxh+/QHFqcRvo9/s28g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrtddtgdeifecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdetrhhn ugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrghtth gvrhhnpeevhfffledtgeehfeffhfdtgedvheejtdfgkeeuvefgudffteettdekkeeufeeh udenucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomheprghrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id BE4B9B60089; Thu, 28 Sep 2023 11:48:38 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-958-g1b1b911df8-fm-20230927.002-g1b1b911d Precedence: bulk X-Mailing-List: gfs2@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <6020d6e7-b187-4abb-bf38-dc09d8bd0f6d@app.fastmail.com> In-Reply-To: <20230928110554.34758-2-jlayton@kernel.org> References: <20230928110554.34758-1-jlayton@kernel.org> <20230928110554.34758-2-jlayton@kernel.org> Date: Thu, 28 Sep 2023 11:48:16 -0400 From: "Arnd Bergmann" To: "Jeff Layton" , "Alexander Viro" , "Christian Brauner" , "Linus Torvalds" , "David Sterba" , "Amir Goldstein" , "Theodore Ts'o" , "Eric W. Biederman" , "Kees Cook" , "Jeremy Kerr" , "Michael Ellerman" , "Nicholas Piggin" , "Christophe Leroy" , "Heiko Carstens" , "Vasily Gorbik" , "Alexander Gordeev" , "Christian Borntraeger" , "Sven Schnelle" , "Greg Kroah-Hartman" , =?UTF-8?Q?Arve_Hj=C3=B8nnev=C3=A5g?= , "Todd Kjos" , "Martijn Coenen" , "Joel Fernandes" , "Carlos Llamas" , "Suren Baghdasaryan" , "Mattia Dongili" , "Dennis Dalessandro" , "Jason Gunthorpe" , "Leon Romanovsky" , "Brad Warrum" , "Ritu Agarwal" , "Hans de Goede" , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , "Mark Gross" , "Jiri Slaby" , "Eric Van Hensbergen" , "Latchesar Ionkov" , "Dominique Martinet" , "Christian Schoenebeck" , "David Sterba" , "David Howells" , "Marc Dionne" , "Ian Kent" , "Luis de Bethencourt" , "Salah Triki" , "Tigran A. Aivazian" , "Chris Mason" , "Josef Bacik" , "Xiubo Li" , "Ilya Dryomov" , "Jan Harkes" , coda@cs.cmu.edu, "Joel Becker" , "Christoph Hellwig" , "Nicolas Pitre" , "Rafael J . Wysocki" , "Ard Biesheuvel" , "Gao Xiang" , "Chao Yu" , "Yue Hu" , "Jeffle Xu" , "Namjae Jeon" , "Sungjong Seo" , "Jan Kara" , "Andreas Dilger" , "Jaegeuk Kim" , "OGAWA Hirofumi" , "Christoph Hellwig" , "Miklos Szeredi" , "Bob Peterson" , "Andreas Gruenbacher" , "Richard Weinberger" , "Anton Ivanov" , "Johannes Berg" , "Mikulas Patocka" , "Mike Kravetz" , "Muchun Song" , "Jan Kara" , "David Woodhouse" , "Dave Kleikamp" , "Tejun Heo" , "Trond Myklebust" , "Anna Schumaker" , "Chuck Lever" , "Neil Brown" , "Olga Kornievskaia" , "Dai Ngo" , "Tom Talpey" , "Ryusuke Konishi" , "Anton Altaparmakov" , "Konstantin Komarov" , "Mark Fasheh" , "Joseph Qi" , "Bob Copeland" , "Mike Marshall" , "Martin Brandenburg" , "Luis Chamberlain" , "Iurii Zaikin" , "Tony Luck" , "Guilherme G. Piccoli" , "Anders Larsen" , "Steve French" , "Paulo Alcantara" , "Ronnie Sahlberg" , "Shyam Prasad N" , "Sergey Senozhatsky" , "Phillip Lougher" , "Steven Rostedt" , "Masami Hiramatsu" , "Evgeniy Dushistov" , "Chandan Babu R" , "Darrick J. Wong" , "Damien Le Moal" , "Naohiro Aota" , "Johannes Thumshirn" , "Alexei Starovoitov" , "Daniel Borkmann" , "Andrii Nakryiko" , "Martin KaFai Lau" , "Song Liu" , "Yonghong Song" , "John Fastabend" , "KP Singh" , "Stanislav Fomichev" , "Hao Luo" , "Jiri Olsa" , "Hugh Dickins" , "Andrew Morton" , "David S . Miller" , "Eric Dumazet" , "Jakub Kicinski" , "Paolo Abeni" , "John Johansen" , "Paul Moore" , "James Morris" , "Serge E. Hallyn" , "Stephen Smalley" , "Eric Paris" Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-rdma@vger.kernel.org, linux-serial@vger.kernel.org, linux-usb@vger.kernel.org, v9fs@lists.linux.dev, linux-afs@lists.infradead.org, autofs@vger.kernel.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@coda.cs.cmu.edu, linux-efi@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, gfs2@lists.linux.dev, linux-um@lists.infradead.org, linux-mtd@lists.infradead.org, jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, linux-karma-devel@lists.sourceforge.net, devel@lists.orangefs.org, linux-unionfs@vger.kernel.org, linux-hardening@vger.kernel.org, reiserfs-devel@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-trace-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, bpf@vger.kernel.org, Netdev , apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org, selinux@vger.kernel.org Subject: Re: [PATCH 86/87] fs: switch timespec64 fields in inode to discrete integers Content-Type: text/plain On Thu, Sep 28, 2023, at 07:05, Jeff Layton wrote: > This shaves 8 bytes off struct inode, according to pahole. > > Signed-off-by: Jeff Layton FWIW, this is similar to the approach that Deepa suggested back in 2016: https://lore.kernel.org/lkml/1452144972-15802-3-git-send-email-deepa.kernel@gmail.com/ It was NaKed at the time because of the added complexity, though it would have been much easier to do it then, as we had to touch all the timespec references anyway. The approach still seems ok to me, but I'm not sure it's worth doing it now if we didn't do it then. Arnd