gfs2 filesystem and dlm development
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: Andreas Gruenbacher <agruenba@redhat.com>
Cc: gfs2@lists.linux.dev, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 7/8] gfs2: Convert gfs2_end_log_write_bh() to work on a folio
Date: Mon, 10 Mar 2025 03:46:07 +0000	[thread overview]
Message-ID: <Z85gf3GfqNX3enPs@casper.infradead.org> (raw)
In-Reply-To: <CAHc6FU5TcVWAOH+Yu1Q0v2j363NXnm8cd2cA0_ug14MmdTtzqw@mail.gmail.com>

On Sun, Mar 09, 2025 at 10:53:29PM +0100, Andreas Gruenbacher wrote:
> On Sun, Mar 9, 2025 at 9:57 PM Matthew Wilcox <willy@infradead.org> wrote:
> > On Sun, Mar 09, 2025 at 06:33:34PM +0100, Andreas Gruenbacher wrote:
> > > On Mon, Feb 10, 2025 at 2:35 PM Matthew Wilcox (Oracle)
> > > <willy@infradead.org> wrote:
> > > > gfs2_end_log_write() has to handle bios which consist of both pages
> > > > which belong to folios and pages which were allocated from a mempool and
> > > > do not belong to a folio.  It would be cleaner to have separate endio
> > > > handlers which handle each type, but it's not clear to me whether that's
> > > > even possible.
> > > >
> > > > This patch is slightly forward-looking in that page_folio() cannot
> > > > currently return NULL, but it will return NULL in the future for pages
> > > > which do not belong to a folio.
> > > >
> > > > This was the last user of page_has_buffers(), so remove it.
> > >
> > > Right now in for-next, ocfs2 is still using page_has_buffers(), so I'm
> > > going to skip this part.
> >
> > How odd.  I see it removed in 1b426db11ba8 ecee61651d8f 0fad0a824e5c
> > 414ae0a44033 and all of those commits are in 6.14-rc1.
> >
> > $ git show v6.14-rc1:fs/ocfs2/aops.c |grep page_has
> > (no output)
> 
> Hmm, you're right, it's only that automatic test that's based on an
> older kernel. Sorry for the confusion.

Looks like your for-next doesn't include v6.14-rc1.

gfs2            104b4d597ff21b923b1e963c5793efcadeae047e

is the entry in SHA1s for next-20250307.  And:

$ git log v6.14-rc1 ^104b4d597ff21b923b1e963c5793efcadeae047e
shows quite a lot of commits (9847 of them).  So I think you didn't pull
from Linus before branching for the v6.15 merge window.  Not sure how
you manage your trees and how you'd like to improce this situation
(do you rebase?  Do you want to bring in a merge commit of some -rc
version?  If so, which one?)

  reply	other threads:[~2025-03-10  3:46 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-10 13:34 [PATCH 0/8] More GFS2 folio conversions Matthew Wilcox (Oracle)
2025-02-10 13:34 ` [PATCH 1/8] gfs2: Use b_folio in gfs2_log_write_bh() Matthew Wilcox (Oracle)
2025-02-10 13:34 ` [PATCH 2/8] gfs2: Use b_folio in gfs2_trans_add_meta() Matthew Wilcox (Oracle)
2025-02-10 13:34 ` [PATCH 3/8] gfs2: Use b_folio in gfs2_submit_bhs() Matthew Wilcox (Oracle)
2025-02-10 13:34 ` [PATCH 4/8] gfs2: Use b_folio in gfs2_check_magic() Matthew Wilcox (Oracle)
2025-02-10 13:34 ` [PATCH 5/8] gfs2: Convert gfs2_jhead_pg_srch() to gfs2_jhead_folio_srch() Matthew Wilcox (Oracle)
2025-02-10 13:34 ` [PATCH 6/8] gfs2: Convert gfs2_find_jhead() to use a folio Matthew Wilcox (Oracle)
2025-03-09 19:43   ` Andreas Gruenbacher
2025-02-10 13:34 ` [PATCH 7/8] gfs2: Convert gfs2_end_log_write_bh() to work on " Matthew Wilcox (Oracle)
2025-03-09 17:33   ` Andreas Gruenbacher
2025-03-09 20:57     ` Matthew Wilcox
2025-03-09 21:53       ` Andreas Gruenbacher
2025-03-10  3:46         ` Matthew Wilcox [this message]
2025-03-10 18:14           ` Andreas Gruenbacher
2025-02-10 13:34 ` [PATCH 8/8] gfs2: Convert gfs2_meta_read_endio() to use " Matthew Wilcox (Oracle)
2025-02-20 13:51 ` [PATCH 0/8] More GFS2 folio conversions Matthew Wilcox
2025-03-09 17:33   ` Andreas Gruenbacher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z85gf3GfqNX3enPs@casper.infradead.org \
    --to=willy@infradead.org \
    --cc=agruenba@redhat.com \
    --cc=gfs2@lists.linux.dev \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox