From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f170.google.com (mail-oi1-f170.google.com [209.85.167.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BDF9D532 for ; Thu, 7 Dec 2023 04:59:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fromorbit.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fromorbit.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fromorbit-com.20230601.gappssmtp.com header.i=@fromorbit-com.20230601.gappssmtp.com header.b="Y5zHjIFP" Received: by mail-oi1-f170.google.com with SMTP id 5614622812f47-3b88c29a995so404742b6e.0 for ; Wed, 06 Dec 2023 20:59:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20230601.gappssmtp.com; s=20230601; t=1701925153; x=1702529953; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=jNjuJ70wYcPCgm9fSzOs2on1O3wdVHSIH2LiIdCkx3k=; b=Y5zHjIFPbsie9CZucZkLQ82eXKCz3Qh+XrczSGoqSdp8tWlMk/EE/A7nUWw2KWhoHW SOB5m86nhydyBlIRWU9aUUHNKsnn4PyVGRu9a9OZQTnV6mZ+gBlnjpZVL57SJvr1bt12 GJSQ9mCM/0MczXttnUlj4lic+dSAAr3XalK/6SdGIYeh1gD+ZYyG8Hb5/BmpNDxvYe3O uwYVjobRxFqI75+FiRCBe+iPzHzAufnrlND6C1ybX61G5zaWfgLQZyy/f6NSD/zXy70d UatBfenq0UiGklTJ0T7JC7YSwVx/FLJgcZOtFtTRsort8EPd5RGbmMghODgHMcg4US+o 97Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701925153; x=1702529953; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jNjuJ70wYcPCgm9fSzOs2on1O3wdVHSIH2LiIdCkx3k=; b=d+Re4oP4RGjiz9Edz54nr5yDjooXiLLpkKFzqs7IUu8mtz+zLgvYw7oA8oHqh+m3iX Dro/Kx8Cgzaabr/axUb40Nl1Lc/pW1YLS9+Ns7HCQS400FwD3RClonhS9qoEbwml5vy1 ES+45Mj5xbcgtjaagubwAzWct69DrVpfiCvcgCjb4D10owcpSUAx+RkVegGr32Qmk6uU gSf19jVY05JWb+3SoSh35BqzRUzFnwbLgLwqmr2QQZtLeOEca96IQjZkbk7uO6zodSNC k886gqRXo5eoyyFzoqh6s6zwpznMU83XK3cQGczRTnFyzFuh5/T6Be1bSa291tNJ8u3d q7Xg== X-Gm-Message-State: AOJu0YzGIZZsmq1HRUdZ8I97cXJ0x8y0lzFpapsPrdImJjp2CnOrnr5n QzyJ4U3QyoCUOTS5OndYPmsB1g== X-Google-Smtp-Source: AGHT+IEdmwUMzlCe4IXUpFIlutTUzo8JXxqf4Rr5coCve5YDCgo/MD/d8kxJh+Eiwruhtft9enzuUA== X-Received: by 2002:a05:6808:4492:b0:3b8:b063:a1d8 with SMTP id eq18-20020a056808449200b003b8b063a1d8mr2287992oib.98.1701925153685; Wed, 06 Dec 2023 20:59:13 -0800 (PST) Received: from dread.disaster.area (pa49-180-125-5.pa.nsw.optusnet.com.au. [49.180.125.5]) by smtp.gmail.com with ESMTPSA id d21-20020aa78695000000b006cb903ab057sm376426pfo.83.2023.12.06.20.59.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Dec 2023 20:59:13 -0800 (PST) Received: from dave by dread.disaster.area with local (Exim 4.96) (envelope-from ) id 1rB6Te-004vzJ-2E; Thu, 07 Dec 2023 15:59:10 +1100 Date: Thu, 7 Dec 2023 15:59:10 +1100 From: Dave Chinner To: Al Viro Cc: linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-cachefs@redhat.com, dhowells@redhat.com, gfs2@lists.linux.dev, dm-devel@lists.linux.dev, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 03/11] vfs: Use dlock list for superblock's inode list Message-ID: References: <20231206060629.2827226-1-david@fromorbit.com> <20231206060629.2827226-4-david@fromorbit.com> <20231207024024.GU1674809@ZenIV> Precedence: bulk X-Mailing-List: gfs2@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231207024024.GU1674809@ZenIV> On Thu, Dec 07, 2023 at 02:40:24AM +0000, Al Viro wrote: > On Wed, Dec 06, 2023 at 05:05:32PM +1100, Dave Chinner wrote: > > > @@ -303,6 +303,7 @@ static void destroy_unused_super(struct super_block *s) > > super_unlock_excl(s); > > list_lru_destroy(&s->s_dentry_lru); > > list_lru_destroy(&s->s_inode_lru); > > + free_dlock_list_heads(&s->s_inodes); > > security_sb_free(s); > > put_user_ns(s->s_user_ns); > > kfree(s->s_subtype); > > Umm... Who's going to do that on normal umount? Huh. So neither KASAN nor kmemleak has told me that s->s-inodes was being leaked. I'm guessing a rebase sometime in the past silently dropped a critical hunk from deactivate_locked_super() in the bit bucket, but as nothing since whenever that happened has failed or flagged a memory leak I didn't notice. Such great tools we have...... -Dave. -- Dave Chinner david@fromorbit.com