public inbox for gfs2@lists.linux.dev
 help / color / mirror / Atom feed
From: Paulo Alcantara <pc@manguebit.com>
To: Alexander Aring <aahringo@redhat.com>, Zorro Lang <zlang@kernel.org>
Cc: Zorro Lang <zlang@redhat.com>, Steve French <smfrench@gmail.com>,
	fstests@vger.kernel.org, gfs2@lists.linux.dev,
	jlayton@kernel.org, linux-cifs@vger.kernel.org
Subject: Re: [PATCHv2] generic: add fcntl corner cases tests
Date: Fri, 01 Mar 2024 13:25:10 -0300	[thread overview]
Message-ID: <a5eb6c3a2de1b959117d49c436b81904@manguebit.com> (raw)
In-Reply-To: <CAK-6q+jZVfK2=Z6RCCU+K+TLYuHgC4ynqOBz3K-nhcypCoN3ww@mail.gmail.com>

Hi Zorro,

The problem is that cifs.ko is returning -EACCES from fcntl(2) called
in do_test_equal_file_lock() but it is expecting -EAGAIN to be
returned, so it hangs in wait4(2):

...
[pid 14846] fcntl(3, F_SETLK, {l_type=F_WRLCK, l_whence=SEEK_SET, l_start=0, l_len=1}) = -1 EACCES (Permission denied)
[pid 14846] wait4(-1,

The man page says:

      F_SETLK (struct flock *)
              Acquire a lock (when l_type is F_RDLCK or F_WRLCK) or release  a
              lock  (when  l_type  is  F_UNLCK)  on the bytes specified by the
              l_whence, l_start, and l_len fields of lock.  If  a  conflicting
              lock  is  held by another process, this call returns -1 and sets
              errno to EACCES or EAGAIN.  (The error  returned  in  this  case
              differs across implementations, so POSIX requires a portable ap‐
              plication to check for both errors.)

so fcntl_lock_corner_tests should also handle -EACCES.

  reply	other threads:[~2024-03-01 16:25 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-25 20:18 [PATCHv2] generic: add fcntl corner cases tests Alexander Aring
2023-11-02 14:37 ` Alexander Aring
2024-02-01 15:03   ` Alexander Aring
2024-02-01 17:10 ` Jeff Layton
2024-02-02 12:04   ` Zorro Lang
2024-02-02 12:19     ` Alexander Aring
2024-02-02 12:27       ` Zorro Lang
2024-02-02 12:36         ` Jeff Layton
2024-02-02 12:46           ` Zorro Lang
2024-02-09  5:26 ` Zorro Lang
2024-02-09  5:35   ` Steve French
2024-02-09 11:43     ` Zorro Lang
2024-03-01 10:38       ` Zorro Lang
2024-03-01 14:08         ` Alexander Aring
2024-03-01 16:25           ` Paulo Alcantara [this message]
2024-03-01 17:23             ` Alexander Aring
2024-03-01 23:59               ` Paulo Alcantara
2024-03-03  5:08                 ` Zorro Lang
2024-03-07 15:58 ` Anand Jain
2024-03-30  7:25 ` Zorro Lang
2024-04-02 14:56   ` Alexander Aring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a5eb6c3a2de1b959117d49c436b81904@manguebit.com \
    --to=pc@manguebit.com \
    --cc=aahringo@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=gfs2@lists.linux.dev \
    --cc=jlayton@kernel.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=smfrench@gmail.com \
    --cc=zlang@kernel.org \
    --cc=zlang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox