From: Christoph Hellwig <hch@infradead.org>
To: Andreas Gruenbacher <agruenba@redhat.com>
Cc: Brian Foster <bfoster@redhat.com>,
Christian Brauner <brauner@kernel.org>,
Christoph Hellwig <hch@infradead.org>,
Matthew Wilcox <willy@infradead.org>,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
gfs2@lists.linux.dev
Subject: Re: [RFC] gfs2: Do not call iomap_zero_range beyond eof
Date: Thu, 8 May 2025 07:17:20 -0700 [thread overview]
Message-ID: <aBy88J4igluFUiNb@infradead.org> (raw)
In-Reply-To: <20250508133427.3799322-1-agruenba@redhat.com>
On Thu, May 08, 2025 at 03:34:27PM +0200, Andreas Gruenbacher wrote:
> As an alternative approach, we could also implicitly truncate the range
> inside iomap_zero_range() instead of issuing a warning. Any thoughts?
I'd rather not magically change the range.
> BUG_ON(current->journal_info);
> + if (from + length > inode->i_size)
> + length = inode->i_size - from;
length = min(length, inode->i_size - from);
next prev parent reply other threads:[~2025-05-08 14:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-08 13:34 [RFC] gfs2: Do not call iomap_zero_range beyond eof Andreas Gruenbacher
2025-05-08 14:17 ` Christoph Hellwig [this message]
2025-05-08 14:30 ` Brian Foster
2025-05-08 15:04 ` Darrick J. Wong
2025-05-08 15:19 ` Brian Foster
2025-05-08 16:04 ` Darrick J. Wong
2025-05-08 16:34 ` Brian Foster
2025-05-08 16:36 ` Andreas Gruenbacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aBy88J4igluFUiNb@infradead.org \
--to=hch@infradead.org \
--cc=agruenba@redhat.com \
--cc=bfoster@redhat.com \
--cc=brauner@kernel.org \
--cc=gfs2@lists.linux.dev \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox