public inbox for gfs2@lists.linux.dev
 help / color / mirror / Atom feed
From: David Teigland <teigland@redhat.com>
To: Alessio Attilio <alessio.attilio.dev@gmail.com>
Cc: Alexander Aring <aahringo@redhat.com>,
	gfs2@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix(dlm): handle unlock/cancel during deferred lock messages
Date: Fri, 29 Aug 2025 13:05:42 -0500	[thread overview]
Message-ID: <aLHr5VAuXQZE0bBd@redhat.com> (raw)
In-Reply-To: <20250829110749.500571-1-226562783+SigAttilio@users.noreply.github.com>

On Fri, Aug 29, 2025 at 01:07:49PM +0200, Alessio Attilio wrote:
> ---
>  fs/dlm/lock.c | 8067 ++++++++++++++++++++++++-------------------------
>  1 file changed, 3944 insertions(+), 4123 deletions(-)

Thanks for working on this, lock cancel has always been sketchy, and I'd
be happy to see that improved.  An 8000 line patch is going to be
difficult to review, though!  It looks like diff may just be moving a lot
of lines around, and perhaps splitting this up could avoid some of that?
Also, I'm not seeing which upstream commit the patch is against.

Thanks,
Dave



      parent reply	other threads:[~2025-08-29 18:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-29 11:07 [PATCH] fix(dlm): handle unlock/cancel during deferred lock messages Alessio Attilio
2025-08-29 13:53 ` Alexander Aring
     [not found]   ` <CACsb0NhQ8BBzcUtR0awMu6AbP-xwLvkUotDAAg-LbUV_LxwiNA@mail.gmail.com>
2025-08-29 16:01     ` Alexander Aring
     [not found]       ` <CACsb0Nh0B5F51H-_bxM+wR4JzD3dJFRfRx_fHGorU=fRYzxPzg@mail.gmail.com>
2025-08-29 17:17         ` Alexander Aring
2025-08-29 18:05 ` David Teigland [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aLHr5VAuXQZE0bBd@redhat.com \
    --to=teigland@redhat.com \
    --cc=aahringo@redhat.com \
    --cc=alessio.attilio.dev@gmail.com \
    --cc=gfs2@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox