From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D021F3624C4 for ; Tue, 10 Mar 2026 18:40:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773168052; cv=none; b=ebLzzmTVAcbQunQfwojzGL30Aj/jsp3/jeK1knADgmiN9hnEDHqMSGLdF5mJK/t54dzGP3cSmrAf6gF3p8vc1v8bHEIkZYtPuv8qUPjPC5l5KyPjxTP9Ty9koqPePRrmh35kpX+R54jJaVpVVG7K204Bihheg5+S4prplXH+7c4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773168052; c=relaxed/simple; bh=67BO0RZg8rxb/E50RmGcBJlsPR5Ae9xmCy+Q7v8QtDY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=eYq0jhtxtkJEBJfA2amrKu4p7VqKRcMa2HJ8aKvfKiotppQSpqGKSupaJLHjFqyn9MLnh3l6j5EBEfQWchLwXJzDKtWg8NVOBoC6htWu+9W300cQ++4ozyffTG/q16XjGx7VwzTN8t6RAacAhiPLU+Vl0LLYFFr31XRFrUN/Jl4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=l7G+/4qr; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="l7G+/4qr" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2ae88e16485so25594535ad.0 for ; Tue, 10 Mar 2026 11:40:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773168050; x=1773772850; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=bjFZ9oZWWc3RZ4UdO5rq+AZbr7uPDX73K58gh1+yuH0=; b=l7G+/4qr5ViVAhZarVR7sYpVC7nNDWFrgTmkDh+IglL4EDFBXK5kmtbOmHOOE+m7ZA oKRsbZuBJJAcyKXm0p11yiTyLVNTT3VS6ZYXQOnexXwVrdImouiIT6OxswPKVswgV5TT cZK8/R9LzrIGilaVm9CRyDF9trvvbdsbxVwvj+BxRbswXmqkMFvaykVZWCkLmkxY1Uut EyaAfbgOPiY9V9eQcoQgNBtyOL2YIDI52loZZxfirEb6793tjh4ysr+VcQ0DGCw/0aL8 eaymqqt667p5TCNw5hKBc1bqNC8HMwCk6SSFkfjVmoLNSGP1YKoKT23V20lcfhx27Q0I JatQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773168050; x=1773772850; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bjFZ9oZWWc3RZ4UdO5rq+AZbr7uPDX73K58gh1+yuH0=; b=eCPYv9RA5ILcWvWqCvQK5m75q6+uViZ3NdqSA9iHPoFEXEfVybxA/LivPcPlEG5LUv UIdLZSvbzrkn+r55SunAwMOnp387Q9JJjpC51pJypA1dppHZTepKjOWRdAdXPmfcLn09 ef9XwpIvLNLK0iIAKpEKKjugh4d5Eo7V2ts1ZzzRxH2sg7gF1XYv+/icUi7vsN62B278 MNtEDqiGZ/j1QRVtyCiOVRx+BubG5O4kUX/nOgtCVlZ0SlRnJtU1C7O01L3qeeCYx3n0 2nrtavQnk/u12rIEFaou/ZiBEhAmRAeov+m7xP64rsA0NsiTGlYXVorPo9QpQkMXFXww Ykbg== X-Forwarded-Encrypted: i=1; AJvYcCVQniI2oFjU5dXBvNI/qBSxAhsyN1/rU5DL3upDfDzwHn7bZwPXvcfUlAR6PdzeB2v04/NM@lists.linux.dev X-Gm-Message-State: AOJu0YxKlrrrrgLCd0kKA+VN+A12hEXV0nLBdPyIMs+y1WgoEIuJaY7h mkin+Sh7PVKgTXa2eKm0ifrl3SbHj6X+vMQEss+4IVb04I0Y0vXKZJXy X-Gm-Gg: ATEYQzwbhhbzbN+5r0vB+wVErUe2ZL7/Muywfk1ATBVtcMfb+kHGAfgTDmWdLu/DAy3 NhRRW5pkRbrjbO/dbycqf/29cxmthyQhrun2iOIsNkUYqdrZPug0BhldBc8DgkEQYhP6kk6dzjR Xu28ZYi4QZ4moWIktTB7oo0bsUNq7YE1lqV2dMk3yaVL3foXWVPm5ueUbPp/tkGGXxBldq+O50n OXPCiHnV+z2ptQpbeZPuBWLDTzv5Yh8tKy24QfGodLrFg1cnO69Z+plB2RdARXF4YR1RO9OZk0h WTbHhl+p7596SLdoxpHjakZ+9MVnrz+3CWKMbiIkrRzkceZlS3X2kdM46xX14izQ2BFZ7Fkw7S+ B7M9HoiVjdat+jkSEMRg1v7ot6ryAstWWV5NCv26VIC+OrbN1MzKCYyfnT8lxgIiWAMPyOaYZub 7ZRy91VNKKWSYltF7Y0qV4ksOHH9xr/jFmWNUkMJhJprhP5A== X-Received: by 2002:a17:903:28c8:b0:2ae:5671:7071 with SMTP id d9443c01a7336-2ae8252cf0fmr96662285ad.43.1773168050081; Tue, 10 Mar 2026 11:40:50 -0700 (PDT) Received: from google.com ([2402:7500:a44:85b:2953:97d3:b283:95c3]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ae83e58592sm220535625ad.14.2026.03.10.11.40.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 11:40:49 -0700 (PDT) Date: Wed, 11 Mar 2026 02:40:36 +0800 From: Kuan-Wei Chiu To: Philipp Hahn Cc: amd-gfx@lists.freedesktop.org, apparmor@lists.ubuntu.com, bpf@vger.kernel.org, ceph-devel@vger.kernel.org, cocci@inria.fr, dm-devel@lists.linux.dev, dri-devel@lists.freedesktop.org, gfs2@lists.linux.dev, intel-gfx@lists.freedesktop.org, intel-wired-lan@lists.osuosl.org, iommu@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-block@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-cifs@vger.kernel.org, linux-clk@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, linux-media@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nfs@vger.kernel.org, linux-omap@vger.kernel.org, linux-phy@lists.infradead.org, linux-pm@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-sctp@vger.kernel.org, linux-security-module@vger.kernel.org, linux-sh@vger.kernel.org, linux-sound@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-trace-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, ntfs3@lists.linux.dev, samba-technical@lists.samba.org, sched-ext@lists.linux.dev, target-devel@vger.kernel.org, tipc-discussion@lists.sourceforge.net, v9fs@lists.linux.dev Subject: Re: [PATCH 00/61] treewide: Use IS_ERR_OR_NULL over manual NULL check - refactor Message-ID: References: <20260310-b4-is_err_or_null-v1-0-bd63b656022d@avm.de> Precedence: bulk X-Mailing-List: gfs2@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260310-b4-is_err_or_null-v1-0-bd63b656022d@avm.de> Hi Philipp, On Tue, Mar 10, 2026 at 12:48:26PM +0100, Philipp Hahn wrote: > While doing some static code analysis I stumbled over a common pattern, > where IS_ERR() is combined with a NULL check. For that there is > IS_ERR_OR_NULL(). > > I've written a Coccinelle patch to find and patch those instances. > The patches follow grouped by subsystem. > > Patches 55-58 may be dropped as they have a (minor?) semantic change: > They use WARN_ON() or WARN_ON_ONCE(), but only in the IS_ERR() path, not > for the NULL check. Iff it is okay to print the warning also for NULL, > then the patches can be applied. > > While generating the patch set `checkpatch` complained about mixing > [un]likely() with IS_ERR_OR_NULL(), which already uses likely() > internally. I found and fixed several locations, where that combination > has been used. Thanks for the patchset. However, I think we need a explanation for why switching to IS_ERR_OR_NULL() is an improvement over the existing code. IMHO, the necessity of IS_ERR_OR_NULL() often highlights a confusing or flawed API design. It usually implies that the caller is unsure whether a failure results in an error pointer or a NULL pointer. Rather than doing a treewide conversion of this pattern, I believe it would be much more meaningful to review these instances case-by-case and fix the underlying APIs or caller logic instead. Additionally, a treewide refactoring like this has the practical drawback of creating unnecessary merge conflicts when backporting to stable trees. Regards, Kuan-Wei