From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 012BE47F77E for ; Mon, 19 Oct 2026 06:14:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792390494; cv=none; b=r/zFEok4GtQRHvpABtzDZ4pUXpaz+qgulfFbtUOiCry5WU5O0j0yLMjgcke/TJBakSpLRfWyC/fjzLL5Y5w2v5xVxJzqm5A/fvLXfW2N5blw4l+uU36ZlpIB5QqYX4f6Ir+yZuIvWkpWmYWoCp37XXtS2G0hfFnR/bVb0L1hmIY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792390494; c=relaxed/simple; bh=hLviHrUQcnY9d6Hs59o7A7DhG6hJV3vxIcScsJNeYyM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CDYP8HL8qyuh1lnz7lSpnoLFVjI+grYm+P155hpQSna2Xz8Y95PclxJbaCKCaMLFV+qTiI8OURf0A3clr6Z/6wyEO1MhHT2TEE/zjJr+3e9k2MZRhQM33Sy4CPJ6lHhSe5b1ASF7kNZy3crIVDUtlq42wRel5ZHqq3TLC9bUOqs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dsAMJqf7; arc=none smtp.client-ip=209.85.216.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dsAMJqf7" Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-38d489b6b71so934927a91.0 for ; Sun, 18 Oct 2026 23:14:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792390492; x=1792995292; darn=lists.linux.dev; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=CH7/2Pn88Czop2CrZPadAXkcJAGF4wsEW/e1YNB1cxQ=; b=dsAMJqf7dGqTZbGxVwLIoUuVDVwEDvCxwVuBj5CI/eDj1bbHZ3NC9iHtp8dQdeyUbr Y8T5Bl2a51xi/U4+iwYIZNh604Og8hdoiFCLKPme5OrY5KbJYq7f/qniob0HFZ3JDiBR PRkktCBSlM9qzBUv2e55Gg3RtZxgGOorIodImuDB/ukDbvxB6C1kyJpU+yNx6lFaVeV6 rdLkWonVPMZ+fvlJYyPRcscixnoKjIDPkYlZ6akbAtvdrydVEA9jnsT8CoUexgEHQ9T8 +DXew2GxAp/YH2I/cZSUW4hdbweiQuP7rY1SCfZkiABYKwVYeonNksowNQXmCgmeXKq3 rXzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792390492; x=1792995292; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=CH7/2Pn88Czop2CrZPadAXkcJAGF4wsEW/e1YNB1cxQ=; b=lKQuXZ3mv9abge+Gve0pct1f54EjdHb6ukKpfnPWF64zwMDPiEEAqT7fDT7IIMNvZv loFotQ/SeputB7PXO+PU8IkYS04xk6nhxzb5aVnS36y8sxHgdii3v3Tv8xi9ozmkiR3Y 280jyQum+ZHVSKmig3zEJc01E09PpcfubyN06hiyAI6Ky/bd+uQDUEeWi4ntx8pzxli0 CayzfVjlN1poZhVsUrRmAydyMu1EX4sLSTHfel7W6cPZ/ZQDRZizQ0X7HmP26iqSZ8eL rwMETlZsKO2FKAWjFVhcvqsljVR6mJJuCG+p/VxHQiVmiIWf5+aghjG04SFxn8FEnNz4 jnbg== X-Forwarded-Encrypted: i=1; AKwUvBw0rfZCR4fa4A2pAjtjX9hH9HFjG7ZrGVakIYYdStSaPKShgrkF78lZ8dvb32g7uNKeoV2t@lists.linux.dev X-Gm-Message-State: AFq9FYJspDM4AuPmK6bUuhpIXvsu0EkIkcOagB9cAj1CfBAHe+i4EkGO 2zUHOdZE69epcD+ppkYWAZntc32lzkfDSLhsse0t3PY7qrDd8rKERkvG X-Gm-Gg: AYBFou1gV3eJ53Z9Eh0GxzUhTGPqqt7iWRQ9AQ3f+0VW+PMOJ3Cm/cvJC6X2bwEoF/x 5Tte7+J51uzxfIW2EN4LgXDJ88N0cTQ+vM5zNHBh9ky4X9QdQglmJ8MiTZP7iWmVLZq8MjyAVDF DhcgySlrt8PnFLGoupEAVcFtJ8r6ksXTauyQdNS/v+YLMhu1FItNATy1m5dyQiGxEHIJGsSOW7b XzRnw0SWzeaAbskI5ycBuc1elQNlsaBDUn14AgTxDk4fllepl8atHOYq9Z1JQBHeot18Nxav/UK 8LHuQbYYP8ywMY/Bm5RLBXLB7X9GfCdDrQ9e0yglUt1+Dq6tLjUqL9GYWiLVdp10epQqPa1iFPw LpXShjKGnqkO8rFcX63bLlrzmydjLYt6+vbEY7J5u+zg8ONxEyP39wiNcFLCJ2knaPHIElsFpFb tTV168ziMv6+nJ2bPGUruqnFrehxpSdidnVo1WtiR2LWNcDB/bkvCKUyl4eK9E X-Received: by 2002:a17:90b:3851:b0:3ab:c80:9362 with SMTP id 98e67ed59e1d1-3aceeea8f3amr5078332a91.35.1792390492104; Sun, 18 Oct 2026 23:14:52 -0700 (PDT) Received: from localhost ([27.122.242.71]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3ac94794dd9sm19035101a91.12.2026.10.18.23.14.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Oct 2026 23:14:51 -0700 (PDT) Date: Mon, 19 Oct 2026 15:14:46 +0900 From: Hyunchul Lee To: Christian Brauner Cc: Jan Kara , Al Viro , ecryptfs@vger.kernel.org, linux-ext4@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-nilfs@vger.kernel.org, exfat@lists.linux.dev, linux-fsdevel@vger.kernel.org, ntfs@lists.linux.dev, ocfs2-devel@lists.linux.dev, linux-btrfs@vger.kernel.org, gfs2@lists.linux.dev, linux-efi@vger.kernel.org, linux-mtd@lists.infradead.org, linux-xfs@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH RFC 14/28] ntfs: don't set SB_RDONLY after filesystem errors Message-ID: References: <20261012-work-fs-sb_rdonly-v1-0-60743a3dc326@kernel.org> <20261012-work-fs-sb_rdonly-v1-14-60743a3dc326@kernel.org> Precedence: bulk X-Mailing-List: gfs2@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20261012-work-fs-sb_rdonly-v1-14-60743a3dc326@kernel.org> Hi Christian, > diff --git a/fs/ntfs/super.c b/fs/ntfs/super.c > index 4066bacabe37..12ad2ce938ba 100644 > --- a/fs/ntfs/super.c > +++ b/fs/ntfs/super.c > @@ -269,6 +269,8 @@ static int ntfs_reconfigure(struct fs_context *fc) > > ntfs_debug("Entering with remount"); > > + /* Mark the volume dirty first if an error made it read-only. */ > + flush_work(&vol->error_work); > sync_filesystem(sb); > if (sb_rdonly(sb) && !(fc->sb_flags & SB_RDONLY)) { .... return -EROFS; Before this patch, SB_RDONLY is set, so remount,rw returned -EROFS. With this patch, sb_rdonly(sb) is false, so remount,rw skips the check and return success even though writes are rejected with -EROFS. I think that the condition should be test NVolErrors(), for example if ((sb_rdonly(sb) || NVolErrors(vol)) && !(fc->sb_flags & SB_RDONLY)) { -- Thanks, Hyunchul