Re: [PATCH 02/14] fs: lift the FMODE_NOCMTIME check into file_update_time_flags

Chaitanya Kulkarni
2025-11-17T06:38:11Z

On 11/13/25 22:26, Christoph Hellwig wrote:
> FMODE_NOCMTIME used to be just a hack for the legacy XFS handle-based
> "invisible I/O", but commit e5e9b24ab8fa ("nfsd: freeze c/mtime updates
> with outstanding WRITE_ATTRS delegation") started using it from
> generic callers.
>
> I'm not sure other file systems are actually read for this in general,
> so the above commit should get a closer look, but for it to make any
> sense, file_update_time needs to respect the flag.
>
> Lift the check from file_modified_flags to file_update_time so that
> users of file_update_time inherit the behavior and so that all the
> checks are done in one place.
>
> Fixes: e5e9b24ab8fa ("nfsd: freeze c/mtime updates with outstanding WRITE_ATTRS delegation")
> Signed-off-by: Christoph Hellwig<hch@lst.de>

Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>

-ck