From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4137C3A9DA1 for ; Wed, 18 Mar 2026 10:15:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773828912; cv=none; b=nUE5JTqCyWED5oMXg6j9vym8J+xVmjy2q/cjOm8mAjYcYMf6Z0KAnTFDu4qK6pqlfXwlygkvhe0EG0FVhAWW8huHtAwDeuoBKFsWV/QHZImTXEcOlG3bN3qwgsDlGMvgUrSvl9xItYDmtCakbJ+6STJScvTI1hsyWV5fy+iMu+Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773828912; c=relaxed/simple; bh=CXh/U1ihuHA6LZF6ZGQCMi5uhNUQAbZHBzU1hKUTMFA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bbbTPDn5kDmV0ktETOXkIFFRq3fo728jLIriGcJQYJ47aIt+l54wI7Br61zXYUBN0vFpWfE9TSINmDInY2YNj4yNzHjJQmmGmoZC2dF3RHdnuPkw0r+FcBMZWTokjGN3GoUCbLopUssIq1+3mN7l9IR5fvzZQWaA6MH1GnjeTmM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=ofL7rmkW; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=QZGgQxhz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=rjiHoQUv; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=zNi9ATAz; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="ofL7rmkW"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="QZGgQxhz"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="rjiHoQUv"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="zNi9ATAz" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E81F44D3E8; Wed, 18 Mar 2026 10:15:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1773828904; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G+1VVGhqZYl71Og99PfHZP+p6IZxOUEQZFy5WoUgigA=; b=ofL7rmkWroXmYKoz4Ua0Ng9aWiD23VYMTe+oAM94VuC8FjaGtrGH8ViaxPXybcdulB3IG0 Xsp4tzk5UZeNSk+kixuZaB2NXxG1iLKsT9W3nQMFpoAavAvZplb4vmmJKw3Rq6+2OYDROI CbX/XzgpCgTNepSzOq6nchfE/RyhRiE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1773828904; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G+1VVGhqZYl71Og99PfHZP+p6IZxOUEQZFy5WoUgigA=; b=QZGgQxhzYbmuX4YwkGig4p/vc01oUeu5h6o2GOfOinFTSFD0gt2587VSUYAURtDn4Ie+ZJ Bff//Q+taN13UbCQ== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1773828902; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G+1VVGhqZYl71Og99PfHZP+p6IZxOUEQZFy5WoUgigA=; b=rjiHoQUvoZDMSQhHowT/BCbJaXhP2+WNQDABqYfzDG4LDZNOOzx3N731mCeeIA7m17yxC5 rw8Tit8gy/oR01L+c92WCRRNMBkwR+pP8emkdrconjMJgw4x1m6DXT68AIJz16tw94eU3B Z1MSzhFu6xsdLG2a7e6eGgpCSbIw6/Y= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1773828902; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G+1VVGhqZYl71Og99PfHZP+p6IZxOUEQZFy5WoUgigA=; b=zNi9ATAzAXLwGbQsQYK4mOsbjiq3CKVJuacz2Df4c48Ic+wRBZYYH5PMEcyvNO7nBLIAMv FxF9ZYyB6T7/EIBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 2EDEF4273B; Wed, 18 Mar 2026 10:14:59 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id +1NDCCN7umlvWwAAD6G6ig (envelope-from ); Wed, 18 Mar 2026 10:14:59 +0000 Message-ID: Date: Wed, 18 Mar 2026 11:14:51 +0100 Precedence: bulk X-Mailing-List: gfs2@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 01/10 net-next v3] ipv6: convert CONFIG_IPV6 to built-in only and clean up Kconfigs To: Krzysztof Kozlowski , netdev@vger.kernel.org Cc: =?UTF-8?Q?Ricardo_B=2E_Marli=C3=A8re?= , Krzysztof Kozlowski , Geert Uytterhoeven , Jason Gunthorpe , Leon Romanovsky , Selvin Xavier , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Ido Schimmel , Petr Machata , Simon Horman , Saurav Kashyap , Javed Hasan , GR-QLogic-Storage-Upstream@marvell.com, "James E.J. Bottomley" , "Martin K. Petersen" , Nilesh Javali , Manish Rangankar , Varun Prakash , Alexander Aring , David Teigland , Andreas Gruenbacher , Nikolay Aleksandrov , David Ahern , Pablo Neira Ayuso , Florian Westphal , Phil Sutter , David Howells , Marc Dionne , Marcelo Ricardo Leitner , Xin Long , Jon Maloy , Bjorn Andersson , Arnd Bergmann , Shawn Guo , Eric Biggers , Michal Simek , Luca Weiss , Sven Peter , Lad Prabhakar , Kuninori Morimoto , Andrew Morton , Kuan-Wei Chiu , Herbert Xu , Ryota Sakamoto , Kuniyuki Iwashima , Kir Chou , David Gow , Vikas Gupta , Bhargava Marreddy , Rajashekar Hudumula , =?UTF-8?Q?Markus_Bl=C3=B6chl?= , linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-rdma@vger.kernel.org, oss-drivers@corigine.com, linux-scsi@vger.kernel.org, gfs2@lists.linux.dev, bridge@lists.linux.dev, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, linux-afs@lists.infradead.org, linux-sctp@vger.kernel.org, tipc-discussion@lists.sourceforge.net References: <20260317140141.5723-1-fmancera@suse.de> <20260317140141.5723-2-fmancera@suse.de> <69dd007c-16d3-44c2-bc30-4e7f5a95addb@oss.qualcomm.com> Content-Language: en-US From: Fernando Fernandez Mancera In-Reply-To: <69dd007c-16d3-44c2-bc30-4e7f5a95addb@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[100.00%]; SUSPICIOUS_RECIPS(1.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; TAGGED_RCPT(0.00)[netdev]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com,hotmail.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[suse.com,kernel.org,linux-m68k.org,ziepe.ca,broadcom.com,lunn.ch,davemloft.net,google.com,redhat.com,nvidia.com,marvell.com,HansenPartnership.com,oracle.com,chelsio.com,blackwall.org,netfilter.org,strlen.de,nwl.cc,auristor.com,gmail.com,oss.qualcomm.com,arndb.de,amd.com,fairphone.com,bp.renesas.com,renesas.com,linux-foundation.org,gondor.apana.org.au,hotmail.com,davidgow.net,blochl.de,vger.kernel.org,lists.linux-m68k.org,corigine.com,lists.linux.dev,lists.infradead.org,lists.sourceforge.net]; R_RATELIMIT(0.00)[to_ip_from(RLpochko8s1nzzw7sn49btux84)]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; RCPT_COUNT_GT_50(0.00)[69]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.com:email,linux-m68k.org:url,imap1.dmz-prg2.suse.org:helo,suse.de:mid,suse.de:email] X-Spam-Flag: NO X-Spam-Score: -2.80 X-Spam-Level: On 3/18/26 7:51 AM, Krzysztof Kozlowski wrote: > On 17/03/2026 15:00, Fernando Fernandez Mancera wrote: >> Maintaining a modular IPv6 stack offers image size savings for specific >> setups, this benefit is outweighed by the architectural burden it >> imposes on the subsystems on implementation and maintenance. Therefore, >> drop it. >> >> Change CONFIG_IPV6 from tristate to bool. Remove all Kconfig >> dependencies across the tree that explicitly checked for IPV6=m. In >> addition, remove MODULE_DESCRIPTION(), MODULE_ALIAS(), MODULE_AUTHOR() >> and MODULE_LICENSE(). >> >> This is also replacing module_init() by device_initcall(). It is not >> possible to use fs_initcall() as IPv4 does because that creates a race >> condition on IPv6 addrconf. >> >> Finally, modify the default configs from CONFIG_IPV6=m to CONFIG_IPV6=y >> except for m68k as according to the bloat-o-meter the image is >> increasing by 330KB~ and that isn't acceptable. Instead, disable IPv6 on >> this architecture by default. This is aligned with m68k RAM requirements >> and recommendations [1]. >> >> [1] http://www.linux-m68k.org/faq/ram.html >> >> Signed-off-by: Fernando Fernandez Mancera >> Tested-by: Ricardo B. Marlière > > That's a Kconfig/defconfig only patch, so build system. You cannot test > it in a meaning of testing code. Building code is not testing. > I do not agree. This isn't a Kconfig/defconfig only patch. It is taking down some module logic like changing module_init() to device_initcall(). Indeed, on v1, this patch was introducing a regression as it was using fs_initcall(). >> Acked-by: Krzysztof Kozlowski > > You removed important parts of Ack. It was not provided like that. > Sorry about that. I will make sure to include the # arm64 on the next revision. Thanks, Fernando.