From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5587D15959C; Thu, 1 Feb 2024 17:10:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706807446; cv=none; b=KMkvRq5+L8gu/q1TvF/EiG9wU7bHsB80u5EBarLyrggIC+elnd0Wl+YGqzh4A23OrdMhCmeWyz/0tbIyZokZ5HFYsWDrxhcwkjVtZxWM7b2PapoWCXB0s5ZZf2kwpOx4Miwqu3LvBgZE4XrMdP74HAmyhXiH2aegB3PrpVzqU7c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706807446; c=relaxed/simple; bh=l5ytDRztAPf6UMvdLhhnHGcEd5ejgaT7/i3H1RUH8z8=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=TQZeFGAIZa7QwwxmGc+hpMwM4aX1eQlST5JpmRRQbGsTsqBbOhLWS5Jz1Ra5WEVYUxpsuOlEhyCMZadZRLSjODldO5w20NlmigJd0fkpkBAgOP2vPOQbdRB09KDdhBvGM2byWmP9vOMNfPdD65rZx7XcS/W+Eo7kH7W1NCY0XnQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=pKebgBoP; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="pKebgBoP" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BAD2FC433B1; Thu, 1 Feb 2024 17:10:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706807446; bh=l5ytDRztAPf6UMvdLhhnHGcEd5ejgaT7/i3H1RUH8z8=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=pKebgBoPutoxX3M94xJVeg2jE1If6B+zmeiwQMEQpW59Te7WFo6hiFoza5KQMw1kU LG7sZ2FxOidloaLLJtvwG4/v7rINrP8jPrdaxBK4SttO8Ezq6Bn4NbTWVxcLeZ5CvN zyoHZRKUPLNowUlGDkJGmwaOIWxlYthBf5d+v/kQwdcPBCDdQtBWz96/AYTPTpd5D4 zMJLtL7KsBiTaOCQoiToEoTFKHp1imuLg8UjVgzLP6mNzQo23nmqISRvXvPdi0y9Ig K0gHib/ehS3S4u+sJut44JyMAcRn6os6mGIoyUPw8Fo51Jl6KlVBUuq8aP+L2vxiP9 BsYllws0mPjKg== Message-ID: Subject: Re: [PATCHv2] generic: add fcntl corner cases tests From: Jeff Layton To: Alexander Aring , fstests@vger.kernel.org Cc: zlang@redhat.com, gfs2@lists.linux.dev Date: Thu, 01 Feb 2024 12:10:44 -0500 In-Reply-To: <20230925201827.1703857-1-aahringo@redhat.com> References: <20230925201827.1703857-1-aahringo@redhat.com> Autocrypt: addr=jlayton@kernel.org; prefer-encrypt=mutual; keydata=mQINBE6V0TwBEADXhJg7s8wFDwBMEvn0qyhAnzFLTOCHooMZyx7XO7dAiIhDSi7G1NPxwn8jdFUQMCR/GlpozMFlSFiZXiObE7sef9rTtM68ukUyZM4pJ9l0KjQNgDJ6Fr342Htkjxu/kFV1WvegyjnSsFt7EGoDjdKqr1TS9syJYFjagYtvWk/UfHlW09X+jOh4vYtfX7iYSx/NfqV3W1D7EDi0PqVT2h6v8i8YqsATFPwO4nuiTmL6I40ZofxVd+9wdRI4Db8yUNA4ZSP2nqLcLtFjClYRBoJvRWvsv4lm0OX6MYPtv76hka8lW4mnRmZqqx3UtfHX/hF/zH24Gj7A6sYKYLCU3YrI2Ogiu7/ksKcl7goQjpvtVYrOOI5VGLHge0awt7bhMCTM9KAfPc+xL/ZxAMVWd3NCk5SamL2cE99UWgtvNOIYU8m6EjTLhsj8snVluJH0/RcxEeFbnSaswVChNSGa7mXJrTR22lRL6ZPjdMgS2Km90haWPRc8Wolcz07Y2se0xpGVLEQcDEsvv5IMmeMe1/qLZ6NaVkNuL3WOXvxaVT9USW1+/SGipO2IpKJjeDZfehlB/kpfF24+RrK+seQfCBYyUE8QJpvTZyfUHNYldXlrjO6n5MdOempLqWpfOmcGkwnyNRBR46g/jf8KnPRwXs509yAqDB6sELZH+yWr9LQZEwARAQABtCVKZWZmIExheXRvbiA8amxheXRvbkBwb29jaGllcmVkcy5uZXQ+iQI7BBMBAgAlAhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAUCTpXWPAIZAQAKCRAADmhBGVaCFc65D/4gBLNMHopQYgG/9RIM3kgFCCQV0pLv0hcg1cjr+bPI5f1PzJoOVi9s0wBDHwp8+vtHgYhM54yt43uI7Htij0RHFL5eFqoVT4TSfAg2qlvNemJEOY0e4daljjmZM7UtmpGs9NN0r9r50W82eb5Kw5bc/ r0kmR/arUS2st+ecRsCnwAOj6HiURwIgfDMHGPtSkoPpu3DDp/cjcYUg3HaOJuTjtGHFH963B+f+hyQ2BrQZBBE76ErgTDJ2Db9Ey0kw7VEZ4I2nnVUY9B5dE2pJFVO5HJBMp30fUGKvwaKqYCU2iAKxdmJXRIONb7dSde8LqZahuunPDMZyMA5+mkQl7kpIpR6kVDIiqmxzRuPeiMP7O2FCUlS2DnJnRVrHmCljLkZWf7ZUA22wJpepBligemtSRSbqCyZ3B48zJ8g5B8xLEntPo/NknSJaYRvfEQqGxgk5kkNWMIMDkfQOlDSXZvoxqU9wFH/9jTv1/6p8dHeGM0BsbBLMqQaqnWiVt5mG92E1zkOW69LnoozE6Le+12DsNW7RjiR5K+27MObjXEYIW7FIvNN/TQ6U1EOsdxwB8o//Yfc3p2QqPr5uS93SDDan5ehH59BnHpguTc27XiQQZ9EGiieCUx6Zh2ze3X2UW9YNzE15uKwkkuEIj60NvQRmEDfweYfOfPVOueC+iFifbQgSmVmZiBMYXl0b24gPGpsYXl0b25AcmVkaGF0LmNvbT6JAjgEEwECACIFAk6V0q0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEAAOaEEZVoIViKUQALpvsacTMWWOd7SlPFzIYy2/fjvKlfB/Xs4YdNcf9qLqF+lk2RBUHdR/dGwZpvw/OLmnZ8TryDo2zXVJNWEEUFNc7wQpl3i78r6UU/GUY/RQmOgPhs3epQC3PMJj4xFx+VuVcf/MXgDDdBUHaCTT793hyBeDbQuciARDJAW24Q1RCmjcwWIV/pgrlFa4lAXsmhoac8UPc82Ijrs6ivlTweFf16VBc4nSLX5FB3ls7S5noRhm5/Zsd4PGPgIHgCZcPgkAnU1S/A/rSqf3FLpU+CbVBDvlVAnOq9gfNF+QiTlOHdZVIe4gEYAU3CUjbleywQqV02BKxPVM0C5/oVjMVx 3bri75n1TkBYGmqAXy9usCkHIsG5CBHmphv9MHmqMZQVsxvCzfnI5IO1+7MoloeeW/lxuyd0pU88dZsV/riHw87i2GJUJtVlMl5IGBNFpqoNUoqmvRfEMeXhy/kUX4Xc03I1coZIgmwLmCSXwx9MaCPFzV/dOOrju2xjO+2sYyB5BNtxRqUEyXglpujFZqJxxau7E0eXoYgoY9gtFGsspzFkVNntamVXEWVVgzJJr/EWW0y+jNd54MfPRqH+eCGuqlnNLktSAVz1MvVRY1dxUltSlDZT7P2bUoMorIPu8p7ZCg9dyX1+9T6Muc5dHxf/BBP/ir+3e8JTFQBFOiLNdFtB9KZWZmIExheXRvbiA8amxheXRvbkBzYW1iYS5vcmc+iQI4BBMBAgAiBQJOldK9AhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRAADmhBGVaCFWgWD/0ZRi4hN9FK2BdQs9RwNnFZUr7JidAWfCrs37XrA/56olQl3ojn0fQtrP4DbTmCuh0SfMijB24psy1GnkPepnaQ6VRf7Dxg/Y8muZELSOtsv2CKt3/02J1BBitrkkqmHyni5fLLYYg6fub0T/8Kwo1qGPdu1hx2BQRERYtQ/S5d/T0cACdlzi6w8rs5f09hU9Tu4qV1JLKmBTgUWKN969HPRkxiojLQziHVyM/weR5Reu6FZVNuVBGqBD+sfk/c98VJHjsQhYJijcsmgMb1NohAzwrBKcSGKOWJToGEO/1RkIN8tqGnYNp2G+aR685D0chgTl1WzPRM6mFG1+n2b2RR95DxumKVpwBwdLPoCkI24JkeDJ7lXSe3uFWISstFGt0HL8EewP8RuGC8s5h7Ct91HMNQTbjgA+Vi1foWUVXpEintAKgoywaIDlJfTZIl6Ew8ETN/7DLy8bXYgq0XzhaKg3CnOUuGQV5/nl4OAX/3jocT5Cz/OtAiNYj5mLPeL5z2ZszjoCAH6caqsF2oLyA nLqRgDgR+wTQT6gMhr2IRsl+cp8gPHBwQ4uZMb+X00c/Amm9VfviT+BI7B66cnC7Zv6Gvmtu2rEjWDGWPqUgccB7hdMKnKDthkA227/82tYoFiFMb/NwtgGrn5n2vwJyKN6SEoygGrNt0SI84y6hEVbQlSmVmZiBMYXl0b24gPGpsYXl0b25AcHJpbWFyeWRhdGEuY29tPokCOQQTAQIAIwUCU4xmKQIbAwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJEAAOaEEZVoIV1H0P/j4OUTwFd7BBbpoSp695qb6HqCzWMuExsp8nZjruymMaeZbGr3OWMNEXRI1FWNHMtcMHWLP/RaDqCJil28proO+PQ/yPhsr2QqJcW4nr91tBrv/MqItuAXLYlsgXqp4BxLP67bzRJ1Bd2x0bWXurpEXY//VBOLnODqThGEcL7jouwjmnRh9FTKZfBDpFRaEfDFOXIfAkMKBa/c9TQwRpx2DPsl3eFWVCNuNGKeGsirLqCxUg5kWTxEorROppz9oU4HPicL6rRH22Ce6nOAON2vHvhkUuO3GbffhrcsPD4DaYup4ic+DxWm+DaSSRJ+e1yJvwi6NmQ9P9UAuLG93S2MdNNbosZ9P8k2mTOVKMc+GooI9Ve/vH8unwitwo7ORMVXhJeU6Q0X7zf3SjwDq2lBhn1DSuTsn2DbsNTiDvqrAaCvbsTsw+SZRwF85eG67eAwouYk+dnKmp1q57LDKMyzysij2oDKbcBlwB/TeX16p8+LxECv51asjS9TInnipssssUDrHIvoTTXWcz7Y5wIngxDFwT8rPY3EggzLGfK5Zx2Q5S/N0FfmADmKknG/D8qGIcJE574D956tiUDKN4I+/g125ORR1v7bP+OIaayAvq17RP+qcAqkxc0x8iCYVCYDouDyNvWPGRhbLUO7mlBpjW9jK9e2fvZY9iw3QzIPGKtClKZWZmIExheXRvbiA8amVmZi5sYXl0 b25AcHJpbWFyeWRhdGEuY29tPokCOQQTAQIAIwUCU4xmUAIbAwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJEAAOaEEZVoIVzJoQALFCS6n/FHQS+hIzHIb56JbokhK0AFqoLVzLKzrnaeXhE5isWcVg0eoV2oTScIwUSUapy94if69tnUo4Q7YNt8/6yFM6hwZAxFjOXR0ciGE3Q+Z1zi49Ox51yjGMQGxlakV9ep4sV/d5a50M+LFTmYSAFp6HY23JN9PkjVJC4PUv5DYRbOZ6Y1+TfXKBAewMVqtwT1Y+LPlfmI8dbbbuUX/kKZ5ddhV2736fgyfpslvJKYl0YifUOVy4D1G/oSycyHkJG78OvX4JKcf2kKzVvg7/Rnv+AueCfFQ6nGwPn0P91I7TEOC4XfZ6a1K3uTp4fPPs1Wn75X7K8lzJP/p8lme40uqwAyBjk+IA5VGd+CVRiyJTpGZwA0jwSYLyXboX+Dqm9pSYzmC9+/AE7lIgpWj+3iNisp1SWtHc4pdtQ5EU2SEz8yKvDbD0lNDbv4ljI7eflPsvN6vOrxz24mCliEco5DwhpaaSnzWnbAPXhQDWb/lUgs/JNk8dtwmvWnqCwRqElMLVisAbJmC0BhZ/Ab4sph3EaiZfdXKhiQqSGdK4La3OTJOJYZphPdGgnkvDV9Pl1QZ0ijXQrVIy3zd6VCNaKYq7BAKidn5g/2Q8oio9Tf4XfdZ9dtwcB+bwDJFgvvDYaZ5bI3ln4V3EyW5i2NfXazz/GA/I/ZtbsigCFc8ftCBKZWZmIExheXRvbiA8amxheXRvbkBrZXJuZWwub3JnPokCOAQTAQIAIgUCWe8u6AIbAwYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQAA5oQRlWghUuCg/+Lb/xGxZD2Q1oJVAE37uW308UpVSD2tAMJUvFTdDbfe3zKlPDTuVsyNsALBGclPLagJ5ZTP+Vp2irAN9uwBuac BOTtmOdz4ZN2tdvNgozzuxp4CHBDVzAslUi2idy+xpsp47DWPxYFIRP3M8QG/aNW052LaPc0cedYxp8+9eiVUNpxF4SiU4i9JDfX/sn9XcfoVZIxMpCRE750zvJvcCUz9HojsrMQ1NFc7MFT1z3MOW2/RlzPcog7xvR5ENPH19ojRDCHqumUHRry+RF0lH00clzX/W8OrQJZtoBPXv9ahka/Vp7kEulcBJr1cH5Wz/WprhsIM7U9pse1f1gYy9YbXtWctUz8uvDR7shsQxAhX3qO7DilMtuGo1v97I/Kx4gXQ52syh/w6EBny71CZrOgD6kJwPVVAaM1LRC28muq91WCFhs/nzHozpbzcheyGtMUI2Ao4K6mnY+3zIuXPygZMFr9KXE6fF7HzKxKuZMJOaEZCiDOq0anx6FmOzs5E6Jqdpo/mtI8beK+BE7Va6ni7YrQlnT0i3vaTVMTiCThbqsB20VrbMjlhpf8lfK1XVNbRq/R7GZ9zHESlsa35ha60yd/j3pu5hT2xyy8krV8vGhHvnJ1XRMJBAB/UYb6FyC7S+mQZIQXVeAA+smfTT0tDrisj1U5x6ZB9b3nBg65ke5Ag0ETpXRPAEQAJkVmzCmF+IEenf9a2nZRXMluJohnfl2wCMmw5qNzyk0f+mYuTwTCpw7BE2H0yXk4ZfAuA+xdj14K0A1Dj52j/fKRuDqoNAhQe0b6ipo85Sz98G+XnmQOMeFVp5G1Z7r/QP/nus3mXvtFsu9lLSjMA0cam2NLDt7vx3l9kUYlQBhyIE7/DkKg+3fdqRg7qJoMHNcODtQY+n3hMyaVpplJ/l0DdQDbRSZi5AzDM3DWZEShhuP6/E2LN4O3xWnZukEiz688d1ppl7vBZO9wBql6Ft9Og74diZrTN6lXGGjEWRvO55h6ijMsLCLNDRAVehPhZvSlPldtUuvhZLAjdWpwmzbRIwgoQcO51aWeKthpcpj8feDdKdlVjvJO9fgFD5kqZ QiErRVPpB7VzA/pYV5Mdy7GMbPjmO0IpoL0tVZ8JvUzUZXB3ErS/dJflvboAAQeLpLCkQjqZiQ/DCmgJCrBJst9Xc7YsKKS379Tc3GU33HNSpaOxs2NwfzoesyjKU+P35czvXWTtj7KVVSj3SgzzFk+gLx8y2Nvt9iESdZ1Ustv8tipDsGcvIZ43MQwqU9YbLg8k4V9ch+Mo8SE+C0jyZYDCE2ZGf3OztvtSYMsTnF6/luzVyej1AFVYjKHORzNoTwdHUeC+9/07GO0bMYTPXYvJ/vxBFm3oniXyhgb5FtABEBAAGJAh8EGAECAAkFAk6V0TwCGwwACgkQAA5oQRlWghXhZRAAyycZ2DDyXh2bMYvI8uHgCbeXfL3QCvcw2XoZTH2l2umPiTzrCsDJhgwZfG9BDyOHaYhPasd5qgrUBtjjUiNKjVM+Cx1DnieR0dZWafnqGv682avPblfi70XXr2juRE/fSZoZkyZhm+nsLuIcXTnzY4D572JGrpRMTpNpGmitBdh1l/9O7Fb64uLOtA5Qj5jcHHOjL0DZpjmFWYKlSAHmURHrE8M0qRryQXvlhoQxlJR4nvQrjOPMsqWD5F9mcRyowOzr8amasLv43w92rD2nHoBK6rbFE/qC7AAjABEsZq8+TQmueN0maIXUQu7TBzejsEbV0i29z+kkrjU2NmK5pcxgAtehVxpZJ14LqmN6E0suTtzjNT1eMoqOPrMSx+6vOCIuvJ/MVYnQgHhjtPPnU86mebTY5Loy9YfJAC2EVpxtcCbx2KiwErTndEyWL+GL53LuScUD7tW8vYbGIp4RlnUgPLbqpgssq2gwYO9m75FGuKuB2+2bCGajqalid5nzeq9v7cYLLRgArJfOIBWZrHy2m0C+pFu9DSuV6SNr2dvMQUv1V58h0FaSOxHVQnJdnoHn13g/CKKvyg2EMrMt/EfcXgvDwQbnG9we4xJiWOIOcsvrWcB6C6lWBDA+In7w7SXnnok kZWuOsJdJQdmwlWC5L5ln9xgfr/4mOY38B0U= Content-Type: text/plain; charset="ISO-8859-15" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.3 (3.50.3-1.fc39) Precedence: bulk X-Mailing-List: gfs2@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2023-09-25 at 16:18 -0400, Alexander Aring wrote: > This patch adds fcntl corner cases that was being used to confirm issues > on a GFS2 filesystem. The GFS2 filesystem has it's own ->lock() > implementation and in those corner cases issues was being found and > fixed. >=20 > Signed-off-by: Alexander Aring > --- > changes since v2: > - move fcntl tests into one fcntl c file > - remove ofd and same owner tests, should be reflected by only one test > - simplify commit message (remove testname out of it) > - add error messages in fcntl.c to give more information if an error > occur >=20 > src/Makefile | 3 +- > src/fcntl.c | 322 ++++++++++++++++++++++++++++++++++++++++++ > tests/generic/732 | 32 +++++ > tests/generic/732.out | 2 + > 4 files changed, 358 insertions(+), 1 deletion(-) > create mode 100644 src/fcntl.c > create mode 100755 tests/generic/732 > create mode 100644 tests/generic/732.out >=20 > diff --git a/src/Makefile b/src/Makefile > index 2815f919..67f936d3 100644 > --- a/src/Makefile > +++ b/src/Makefile > @@ -19,7 +19,8 @@ TARGETS =3D dirstress fill fill2 getpagesize holes lsta= t64 \ > t_ofd_locks t_mmap_collision mmap-write-concurrent \ > t_get_file_time t_create_short_dirs t_create_long_dirs t_enospc \ > t_mmap_writev_overlap checkpoint_journal mmap-rw-fault allocstale \ > - t_mmap_cow_memory_failure fake-dump-rootino dio-buf-fault rewinddir-tes= t > + t_mmap_cow_memory_failure fake-dump-rootino dio-buf-fault rewinddir-tes= t \ > + fcntl I think this function needs a less-generic name than "fcntl". Other the lock tests themselves look like a nice addition though. > =20 > LINUX_TARGETS =3D xfsctl bstat t_mtab getdevicesize preallo_rw_pattern_r= eader \ > preallo_rw_pattern_writer ftrunc trunc fs_perms testx looptest \ > diff --git a/src/fcntl.c b/src/fcntl.c > new file mode 100644 > index 00000000..8e375357 > --- /dev/null > +++ b/src/fcntl.c > @@ -0,0 +1,322 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* Copyright (c) 2023 Alexander Aring. All Rights Reserved. > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +static char filename[PATH_MAX + 1]; > +static int fd; > + > +static void usage(char *name, const char *msg) > +{ > + printf("Fatal: %s\nUsage:\n" > + "%s \n", msg, name); > + _exit(1); > +} > + > +static void *do_equal_file_lock_thread(void *arg) > +{ > + struct flock fl =3D { > + .l_type =3D F_WRLCK, > + .l_whence =3D SEEK_SET, > + .l_start =3D 0L, > + .l_len =3D 1L, > + }; > + int rv; > + > + rv =3D fcntl(fd, F_SETLKW, &fl); > + if (rv =3D=3D -1) { > + perror("fcntl"); > + _exit(1); > + } > + > + return NULL; > +} > + > +static void do_test_equal_file_lock(void) > +{ > + struct flock fl; > + pthread_t t[2]; > + int pid, rv; > + > + fl.l_type =3D F_WRLCK; > + fl.l_whence =3D SEEK_SET; > + fl.l_start =3D 0L; > + fl.l_len =3D 1L; > + > + /* acquire range 0-0 */ > + rv =3D fcntl(fd, F_SETLK, &fl); > + if (rv =3D=3D -1) { > + perror("fcntl"); > + _exit(1); > + } > + > + pid =3D fork(); > + if (pid =3D=3D 0) { > + rv =3D pthread_create(&t[0], NULL, do_equal_file_lock_thread, NULL); > + if (rv !=3D 0) { > + fprintf(stderr, "failed to create pthread\n"); > + _exit(1); > + } > + > + rv =3D pthread_create(&t[1], NULL, do_equal_file_lock_thread, NULL); > + if (rv !=3D 0) { > + fprintf(stderr, "failed to create pthread\n"); > + _exit(1); > + } > + > + pthread_join(t[0], NULL); > + pthread_join(t[1], NULL); > + > + _exit(0); > + } > + > + /* wait until threads block on 0-0 */ > + sleep(3); > + > + fl.l_type =3D F_UNLCK; > + fl.l_start =3D 0; > + fl.l_len =3D 1; > + rv =3D fcntl(fd, F_SETLK, &fl); > + if (rv =3D=3D -1) { > + perror("fcntl"); > + _exit(1); > + } > + > + sleep(3); > + > + /* check if the ->lock() implementation got the > + * right locks granted because two waiter with the > + * same file_lock fields are waiting > + */ > + fl.l_type =3D F_WRLCK; > + rv =3D fcntl(fd, F_SETLK, &fl); > + if (rv =3D=3D -1 && errno =3D=3D EAGAIN) { > + fprintf(stderr, "deadlock, pthread not cleaned up correctly\n"); > + _exit(1); > + } > + > + wait(NULL); > +} > + > +static void catch_alarm(int num) { } > + > +static void do_test_signal_interrupt_child(int *pfd) > +{ > + struct sigaction act; > + unsigned char m; > + struct flock fl; > + int rv; > + > + fl.l_type =3D F_WRLCK; > + fl.l_whence =3D SEEK_SET; > + fl.l_start =3D 1; > + fl.l_len =3D 1; > + > + rv =3D fcntl(fd, F_SETLK, &fl); > + if (rv =3D=3D -1) { > + perror("fcntl"); > + _exit(1); > + } > + > + memset(&act, 0, sizeof(act)); > + act.sa_handler =3D catch_alarm; > + sigemptyset(&act.sa_mask); > + sigaddset(&act.sa_mask, SIGALRM); > + sigaction(SIGALRM, &act, NULL); > + > + fl.l_type =3D F_WRLCK; > + fl.l_whence =3D SEEK_SET; > + fl.l_start =3D 0; > + fl.l_len =3D 1; > + > + /* interrupt SETLKW by signal in 3 secs */ > + alarm(3); > + rv =3D fcntl(fd, F_SETLKW, &fl); > + if (rv =3D=3D 0) { > + fprintf(stderr, "fcntl interrupt successful but should fail with EINTR= \n"); > + _exit(1); > + } > + > + /* synchronize to move parent to test region 1-1 */ > + write(pfd[1], &m, sizeof(m)); > + > + /* keep child alive */ > + read(pfd[1], &m, sizeof(m)); > +} > + > +static void do_test_signal_interrupt(void) > +{ > + struct flock fl; > + unsigned char m; > + int pid, rv; > + int pfd[2]; > + > + rv =3D pipe(pfd); > + if (rv =3D=3D -1) { > + perror("pipe"); > + _exit(1); > + } > + > + fl.l_type =3D F_WRLCK; > + fl.l_whence =3D SEEK_SET; > + fl.l_start =3D 0; > + fl.l_len =3D 1; > + > + rv =3D fcntl(fd, F_SETLK, &fl); > + if (rv =3D=3D -1) { > + perror("fcntl"); > + _exit(1); > + } > + > + pid =3D fork(); > + if (pid =3D=3D 0) { > + do_test_signal_interrupt_child(pfd); > + _exit(0); > + } > + > + /* wait until child writes */ > + read(pfd[0], &m, sizeof(m)); > + > + fl.l_type =3D F_WRLCK; > + fl.l_whence =3D SEEK_SET; > + fl.l_start =3D 1; > + fl.l_len =3D 1; > + /* parent testing childs region, the child will think > + * it has region 1-1 locked because it was interrupted > + * by region 0-0. Due bugs the interruption also unlocked > + * region 1-1. > + */ > + rv =3D fcntl(fd, F_SETLK, &fl); > + if (rv =3D=3D 0) { > + fprintf(stderr, "fcntl trylock successful but should fail because chil= d still acquires region\n"); > + _exit(1); > + } > + > + write(pfd[0], &m, sizeof(m)); > + > + wait(NULL); > + > + close(pfd[0]); > + close(pfd[1]); > + > + /* cleanup everything */ > + fl.l_type =3D F_UNLCK; > + fl.l_whence =3D SEEK_SET; > + fl.l_start =3D 0; > + fl.l_len =3D 2; > + rv =3D fcntl(fd, F_SETLK, &fl); > + if (rv =3D=3D -1) { > + perror("fcntl"); > + _exit(1); > + } > +} > + > +static void do_test_kill_child(void) > +{ > + struct flock fl; > + int rv; > + > + fl.l_type =3D F_WRLCK; > + fl.l_whence =3D SEEK_SET; > + fl.l_start =3D 0; > + fl.l_len =3D 1; > + > + rv =3D fcntl(fd, F_SETLKW, &fl); > + if (rv =3D=3D -1) { > + perror("fcntl"); > + _exit(1); > + } > +} > + > +static void do_test_kill(void) > +{ > + struct flock fl; > + int pid_to_kill; > + int rv; > + > + fl.l_type =3D F_WRLCK; > + fl.l_whence =3D SEEK_SET; > + fl.l_start =3D 0; > + fl.l_len =3D 1; > + > + rv =3D fcntl(fd, F_SETLK, &fl); > + if (rv =3D=3D -1) { > + perror("fcntl"); > + _exit(1); > + } > + > + pid_to_kill =3D fork(); > + if (pid_to_kill =3D=3D 0) { > + do_test_kill_child(); > + _exit(0); > + } > + > + /* wait until child blocks */ > + sleep(3); > + > + kill(pid_to_kill, SIGKILL); > + > + /* wait until Linux did plock cleanup */ > + sleep(3); > + > + fl.l_type =3D F_UNLCK; > + fl.l_whence =3D SEEK_SET; > + fl.l_start =3D 0; > + fl.l_len =3D 1; > + > + /* cleanup parent lock */ > + rv =3D fcntl(fd, F_SETLK, &fl); > + if (rv =3D=3D -1) { > + perror("fcntl"); > + _exit(1); > + } > + > + fl.l_type =3D F_WRLCK; > + fl.l_whence =3D SEEK_SET; > + fl.l_start =3D 0; > + fl.l_len =3D 1; > + > + /* check if the child still holds the lock > + * and killing the child was not cleaning > + * up locks. > + */ > + rv =3D fcntl(fd, F_SETLK, &fl); > + if ((rv =3D=3D -1 && errno =3D=3D EAGAIN)) { > + fprintf(stderr, "fcntl trylock failed but should be successful because= killing child should cleanup acquired lock\n"); > + _exit(1); > + } > +} > + > +int main(int argc, char * const argv[]) > +{ > + if (optind !=3D argc - 1) > + usage(argv[0], " is mandatory to tell the file where t= o run fcntl() on it"); > + > + strncpy(filename, argv[1], PATH_MAX); > + > + fd =3D open(filename, O_RDWR | O_CREAT, 0700); > + if (fd =3D=3D -1) { > + perror("open"); > + _exit(1); > + } > + > + /* test to have to equal struct file_lock requests in ->lock() */ > + do_test_equal_file_lock(); > + /* test to interrupt F_SETLKW by a signal and cleanup only canceled the= pending interrupted request */ > + do_test_signal_interrupt(); > + /* test if cleanup is correct if a child gets killed while being blocke= d in F_SETLKW */ > + do_test_kill(); > + > + close(fd); > + > + return 0; > +} > diff --git a/tests/generic/732 b/tests/generic/732 > new file mode 100755 > index 00000000..d77f9fc2 > --- /dev/null > +++ b/tests/generic/732 > @@ -0,0 +1,32 @@ > +#! /bin/bash > +# SPDX-License-Identifier: GPL-2.0 > +# Copyright (c) 2023 Alexander Aring. All Rights Reserved. > +# > +# FS QA Test 732 > +# > +# This tests performs some fcntl() corner cases. See fcntl test > +# program for more details. > +# > +. ./common/preamble > +_begin_fstest auto > + > +# Import common functions. > +. ./common/filter > + > +# real QA test starts here > + > +# Modify as appropriate. > +_supported_fs generic > +_require_test > +_require_test_program fcntl > + > +echo "Silence is golden" > + > +$here/src/fcntl $TEST_DIR/testfile > +if [ $? -ne 0 ] > +then > + exit > +fi > + > +status=3D0 > +exit > diff --git a/tests/generic/732.out b/tests/generic/732.out > new file mode 100644 > index 00000000..451f82ce > --- /dev/null > +++ b/tests/generic/732.out > @@ -0,0 +1,2 @@ > +QA output created by 732 > +Silence is golden Assuming you change the name of "fcntl" program, you can add: Reviewed-by: Jeff Layton