From: "Randall S. Becker" <rsbecker@nexbridge.com>
To: "'Derrick Stolee'" <stolee@gmail.com>,
<randall.s.becker@rogers.com>, <git@vger.kernel.org>
Subject: RE: [PATCH v1 3/4] git-compat-util.h: add FLOSS headers for HPE NonStop
Date: Thu, 27 Dec 2018 10:55:01 -0500 [thread overview]
Message-ID: <000001d49dfc$89cadd80$9d609880$@nexbridge.com> (raw)
In-Reply-To: <5712b2bf-8a90-42d7-9159-261dd990eb66@gmail.com>
On December 27, 2018 7:10, Derrick Stolee wrote:
> On 12/26/2018 6:05 PM, randall.s.becker@rogers.com wrote:
> > The NSIG define is also not defined on __TANDEM, so we define it here
> > as 100 if it is not defined only for __TANDEM builds.
> [snip]
> > +#if ! defined NSIG
>
> Why didn't you use "#ifndef" here?
>
> Taking a look at the file, I see both "#ifdef" and "#if defined" but no "#if !
> defined".
I'm good with revising as follows and removing the irrelevant lines (stay tuned):
+#ifdef __TANDEM
+#include <floss.h(floss_execl,floss_execlp,floss_execv,floss_execvp)>
+#include <floss.h(floss_getpwuid)>
+#ifndef NSIG
+/* NonStop NSE and NSX do not provide NSIG. SIGGUARDIAN(99) is the highest
+ known, by detective work using kill -l as a list is all signals
+ instead of signal.h where it should be. */
+# define NSIG 100
+#endif
+#endif
+
Cheers,
Randall
next prev parent reply other threads:[~2018-12-27 15:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-26 23:05 [PATCH v1 0/4] HPE NonStop Port Commits randall.s.becker
2018-12-26 23:05 ` [PATCH v1 1/4] transport-helper: use xread instead of read randall.s.becker
2018-12-28 20:10 ` Junio C Hamano
2018-12-28 20:38 ` Randall S. Becker
2018-12-26 23:05 ` [PATCH v1 2/4] config.mak.uname: support for modern HPE NonStop config randall.s.becker
2018-12-27 17:02 ` Eric Sunshine
2018-12-27 17:44 ` Randall S. Becker
2018-12-28 20:07 ` Junio C Hamano
2018-12-28 20:33 ` Randall S. Becker
2018-12-26 23:05 ` [PATCH v1 3/4] git-compat-util.h: add FLOSS headers for HPE NonStop randall.s.becker
2018-12-27 12:10 ` Derrick Stolee
2018-12-27 15:55 ` Randall S. Becker [this message]
2018-12-26 23:05 ` [PATCH v1 4/4] compat/regex/regcomp.c: define intptr_t and uintptr_t on NonStop randall.s.becker
2018-12-27 12:12 ` [PATCH v1 0/4] HPE NonStop Port Commits Derrick Stolee
2018-12-27 16:01 ` Randall S. Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000001d49dfc$89cadd80$9d609880$@nexbridge.com' \
--to=rsbecker@nexbridge.com \
--cc=git@vger.kernel.org \
--cc=randall.s.becker@rogers.com \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).