git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Gerald Gutierrez" <ggmlfs@gmail.com>
To: "'Johannes Schindelin'" <Johannes.Schindelin@gmx.de>
Cc: "'Junio C Hamano'" <gitster@pobox.com>,
	"'Matthieu Moy'" <Matthieu.Moy@imag.fr>, <git@vger.kernel.org>
Subject: RE: git with custom diff for commits
Date: Tue, 18 Dec 2007 13:51:38 -0800	[thread overview]
Message-ID: <000201c841c0$2e5e08e0$762a14ac@na.acco.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0712182124410.23902@racer.site>

 
> -----Original Message-----
> From: Johannes Schindelin [mailto:Johannes.Schindelin@gmx.de] 
> Sent: Tuesday, December 18, 2007 1:27 PM
> To: Gerald Gutierrez
> Cc: 'Junio C Hamano'; 'Matthieu Moy'; git@vger.kernel.org
> Subject: RE: git with custom diff for commits
> 
> Hi,
> 
> On Tue, 18 Dec 2007, Gerald Gutierrez wrote:
> 
> > Yes, but wouldn't it be slick to actually teach git's 
> internal diff to 
> > do things like GNU diff can, like the ignore option -I, case 
> > insensitivity, etc. I thought that's what the external diff 
> capability 
> > is for, but it is not so.
> 
> I disagree.  Your statement is misleading when you say you 
> want the internal diff to do things like GNU diff can.
> 
> What you want to do _in fact_ is not only modify the diff 
> _output_, but the commit _input_.
> 
> And I am not so keen on such filters.  If I do not want to 
> commit,  I do not change it to begin with.  Yes, your 
> mysqldump is a special case here.  
> But it is special anyway, as it is not source code.

I don't understand how it is a benefit to have "git commit" and "git diff"
do different diff functions. It confuses me. A scenario: I keep doing git
diff's and it says there is no difference, but then git commit keeps telling
me there is.

While I understand it was built for the kernel and everybody likes the plain
text format, it is not a stretch of the imagination to have files that are
semantically identical but have byte-wise differences. OpenDocument files,
image files, XML, etc. Cases can be made either way that "the same" means
semantically or byte-wise. It's perfectly fine that the default is
byte-wise. But, if the user takes the time to build a custom diff, then
wouldn't it be reasonable to assume that user means for git to do semantic
comparisons for diff, commit and other git functions, even if there are
inconsequential byte-wise differences in the file itself?

Gerald.

  reply	other threads:[~2007-12-18 21:50 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-17 22:56 git with custom diff for commits Gerald Gutierrez
2007-12-17 23:01 ` Johannes Schindelin
2007-12-17 23:08   ` Matthieu Moy
2007-12-17 23:11     ` Johannes Schindelin
2007-12-17 23:26       ` Junio C Hamano
2007-12-18  8:57         ` Matthieu Moy
2007-12-18  9:25           ` Junio C Hamano
2007-12-18 20:35             ` Gerald Gutierrez
2007-12-18 20:40               ` Junio C Hamano
2007-12-18 20:48                 ` Gerald Gutierrez
2007-12-18 21:27                   ` Johannes Schindelin
2007-12-18 21:51                     ` Gerald Gutierrez [this message]
2007-12-18 22:00                       ` Johannes Schindelin
2007-12-18 21:38                   ` Junio C Hamano
2007-12-18 21:51                   ` Matthieu Moy
2007-12-18 22:27                     ` Gerald Gutierrez
2007-12-18 22:48                       ` Johannes Schindelin
2007-12-18 23:52                         ` Martin Langhoff
2007-12-19  9:01                         ` Matthieu Moy
2007-12-19 12:09                           ` Johannes Schindelin
2007-12-19 12:13                             ` Matthieu Moy
2007-12-19  9:13                       ` Matthieu Moy
2007-12-18 22:29                     ` Gerald Gutierrez
2007-12-17 23:27       ` Gerald Gutierrez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000201c841c0$2e5e08e0$762a14ac@na.acco.com' \
    --to=ggmlfs@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=Matthieu.Moy@imag.fr \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).