From: "Joachim Schmitz" <jojo@schmitz-digital.de>
To: "'Junio C Hamano'" <gitster@pobox.com>
Cc: <git@vger.kernel.org>
Subject: RE: [PATCH v7 1/4] make poll available for other platforms lacking it
Date: Tue, 18 Sep 2012 09:02:24 +0200 [thread overview]
Message-ID: <000301cd956b$8f29c110$ad7d4330$@schmitz-digital.de> (raw)
In-Reply-To: <7vehlzq0r3.fsf@alter.siamese.dyndns.org>
> From: Junio C Hamano [mailto:gitster@pobox.com]
> Sent: Tuesday, September 18, 2012 8:55 AM
> To: Joachim Schmitz
> Cc: git@vger.kernel.org
> Subject: Re: [PATCH v7 1/4] make poll available for other platforms lacking it
>
> "Joachim Schmitz" <jojo@schmitz-digital.de> writes:
>
> >> > @@ -1605,6 +1610,11 @@ ifdef NO_GETTEXT
> >> > BASIC_CFLAGS += -DNO_GETTEXT
> >> > USE_GETTEXT_SCHEME ?= fallthrough
> >> > endif
> >> > +ifdef NO_POLL
> >> > + NO_SYS_POLL_H = YesPlease
> >> > + COMPAT_CFLAGS += -DNO_POLL -Icompat/poll
> >> > + COMPAT_OBJS += compat/poll/poll.o
> >> > +endif
> >>
> >> I think my guesses above are correct, so will queue with the trivial
> >> and obvious fixup.
> >
> > Well I was unde the impression that is <sys/poll.h> isn't
> > available, there might be a <poll.h> and it that isn't available
> > either we use compat/.../poll.[ch]. But rethinking your changed
> > does makes perfect sense.
>
> Heh, my comment was not about names between NO_POLL_H vs NO_POLL.
> With the way you wrote the code, the symbols defined for Windows and
> MINGW must match what controls the hunk around ll.1610, so what
> makes perfect sense to you is indeed your code ;-)
Yeah, I do understand myself pretty good ;-)
Now I see my typo...
prev parent reply other threads:[~2012-09-18 7:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-17 21:16 [PATCH v7 1/4] make poll available for other platforms lacking it Joachim Schmitz
2012-09-17 22:41 ` Junio C Hamano
2012-09-18 6:28 ` Joachim Schmitz
2012-09-18 6:54 ` Junio C Hamano
2012-09-18 7:02 ` Joachim Schmitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000301cd956b$8f29c110$ad7d4330$@schmitz-digital.de' \
--to=jojo@schmitz-digital.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).