git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Joachim Schmitz" <jojo@schmitz-digital.de>
To: "'Jan Engelhardt'" <jengelh@inai.de>
Cc: "'Junio C Hamano'" <gitster@pobox.com>, <git@vger.kernel.org>
Subject: RE: git on HP NonStop
Date: Mon, 20 Aug 2012 12:36:37 +0200	[thread overview]
Message-ID: <000701cd7ebf$af552aa0$0dff7fe0$@schmitz-digital.de> (raw)
In-Reply-To: <alpine.LNX.2.01.1208191824100.29175@frira.zrqbmnf.qr>

> From: Jan Engelhardt [mailto:jengelh@inai.de]
> Sent: Sunday, August 19, 2012 6:26 PM
> To: Joachim Schmitz
> Cc: 'Junio C Hamano'; git@vger.kernel.org
> Subject: RE: git on HP NonStop
> 
> 
> On Tuesday 2012-08-14 17:52, Joachim Schmitz wrote:
> > @@ -98,6 +99,11 @@
> > #include <stdlib.h>
> > #include <stdarg.h>
> > #include <string.h>
> >+#ifdef __TANDEM
> >+# include <strings.h> /* for strcasecmp() */
> >+  typedef int intptr_t; /* not "int *" ?!? */
> >+  typedef unsigned int uintptr_t; /* not "unsigned int *" ?!? */
> 
> Of course not. intptr_t is an integral value capable of holding a pointer;
it is not
> a pointer to int (because that would really be redundant to int*.)

OK, thanks for the clarification.

Another issue I stumbled across:
There are numerous places (well, some 10) were something like the following
is done

int var = var;
char *othervar = othervar;

Here this leads to Compiler warnings  'variable "var" is used before its
value is set' on NonStop. This self-initialization seems to be a GCC
extension (?), but even gcc has a -Winit-self option to warn about this.
Shouldn't that better be like the following?

int var = 0;
char *othervar = NULL;

What is the reason for using that self-init stuff? I don't think it is
really portable, is it?

Bye, Jojo

  reply	other threads:[~2012-08-20 10:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <001101cd79f2$f21b3bd0$d651b370$@schmitz-digital.de>
     [not found] ` <7vr4r98rfd.fsf@alter.siamese.dyndns.org>
2012-08-14 15:52   ` git on HP NonStop Joachim Schmitz
2012-08-19 16:25     ` Jan Engelhardt
2012-08-20 10:36       ` Joachim Schmitz [this message]
2012-08-20 10:56         ` Johannes Sixt
2012-08-20 11:27           ` Joachim Schmitz
2012-08-20 16:29           ` Junio C Hamano
2012-08-20 20:51             ` Joachim Schmitz
2012-08-21  2:06               ` Junio C Hamano
2012-08-22 16:38                 ` Joachim Schmitz
2012-08-23  8:23                   ` Andreas Ericsson
2012-08-23  9:23                     ` Joachim Schmitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000701cd7ebf$af552aa0$0dff7fe0$@schmitz-digital.de' \
    --to=jojo@schmitz-digital.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jengelh@inai.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).