From: "Randall S. Becker" <rsbecker@nexbridge.com>
To: "'Junio C Hamano'" <gitster@pobox.com>, "'Johannes Sixt'" <j6t@kdbg.org>
Cc: "'Carlo Arenas'" <carenas@gmail.com>, <shoelzer@gmail.com>,
<gitgitgadget@gmail.com>, <git@vger.kernel.org>,
<johannes.schindelin@gmx.de>
Subject: RE: [PATCH 1/1] poll: use GetTickCount64() to avoid wrap-around issues
Date: Sun, 4 Nov 2018 18:44:18 -0500 [thread overview]
Message-ID: <001101d47498$512b4bf0$f381e3d0$@nexbridge.com> (raw)
In-Reply-To: <xmqqefc0mnlh.fsf@gitster-ct.c.googlers.com>
On November 4, 2018 6:26 PM, Junio C Hamano, wrote:
> Johannes Sixt <j6t@kdbg.org> writes:
>
> > Am 03.11.18 um 09:14 schrieb Carlo Arenas:
> >> On Fri, Nov 2, 2018 at 9:44 AM Johannes Sixt <j6t@kdbg.org> wrote:
> >>>
> >>> + timeout = elapsed >= orig_timeout ? 0 : (int)(orig_timeout -
> >>> + elapsed);
> >>
> >> nitpick: cast to DWORD instead of int
> >
> > No; timeout is of type int; after an explicit type cast we don't want
> > to have another implicit conversion.
> >
> > -- Hannes
>
> OK, thanks. It seems that the relative silence after this message is a
sign that
> the resulting patch after squashing is what everybody is happey with?
On my platform (HPE NonStop), DWORD is being defined as unsigned int
(32-bit) rather than unsigned long long (64 bit). The definition comes
through the odbc/windows.h include, not the compiler or any core definition.
It's only a nano-quibble (if even that), because GetTickCount64 is not
defined on the platform anyway, so this is probably not a big deal.
Cheers,
Randall
next prev parent reply other threads:[~2018-11-04 23:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-31 21:11 [PATCH 0/1] Make compat/poll safer on Windows Johannes Schindelin via GitGitGadget
2018-10-31 21:11 ` [PATCH 1/1] poll: use GetTickCount64() to avoid wrap-around issues Steve Hoelzer via GitGitGadget
2018-11-01 10:21 ` Johannes Sixt
2018-11-02 14:47 ` Steve Hoelzer
2018-11-02 16:43 ` Johannes Sixt
2018-11-02 17:18 ` Steve Hoelzer
2018-11-03 0:39 ` Junio C Hamano
2018-11-03 0:49 ` Junio C Hamano
2018-11-03 8:14 ` Carlo Arenas
2018-11-03 14:05 ` Johannes Sixt
2018-11-04 23:26 ` Junio C Hamano
2018-11-04 23:44 ` Randall S. Becker [this message]
2018-11-05 3:33 ` Eric Sunshine
2018-11-05 4:02 ` Junio C Hamano
2018-11-05 7:01 ` Johannes Sixt
2018-11-05 20:28 ` Johannes Sixt
2018-11-05 22:05 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001101d47498$512b4bf0$f381e3d0$@nexbridge.com' \
--to=rsbecker@nexbridge.com \
--cc=carenas@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=johannes.schindelin@gmx.de \
--cc=shoelzer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).