From: "Tjernlund" <tjernlund@tjernlund.se>
To: "'Jakub Narebski'" <jnareb@gmail.com>
Cc: <git@vger.kernel.org>
Subject: RE: gitweb: please show tags file history browsing
Date: Mon, 13 Sep 2010 07:42:12 +0200 [thread overview]
Message-ID: <001601cb5306$6a7d8030$3f788090$@se> (raw)
In-Reply-To: <201009122020.11556.jnareb@gmail.com>
> -----Original Message-----
> From: Jakub Narebski [mailto:jnareb@gmail.com]
> Tjernlund wrote:
> >> On Sun, 12 Sep 2010, Tjernlund wrote:
> >>>> From: Jakub Narebski [mailto:jnareb@gmail.com]
> >>>> On Sun, 12 Sep 2010, Tjernlund wrote:
> >>>>>> From: Jakub Narebski [mailto:jnareb@gmail.com]
>
> >>>>>> While it probably be possible to show tags in 'history' view, it would
> >>>>>> be not easy. The problem is that 'history' view shows only commits
> >>>>>> that touch specified file or directory, and tagged commits usually do
> >>>>>> not touch those files (at least if one is using "bump version number"
> >>>>>> commits to tag them).
> >>>>>>
> >>>>>> So you would have:
> >>>>>> 1. Design where to show those tags - they would be between shown
> >>>>>> commits.
> >>>>>> 2. Create code which shows some/all tags that are between commits in
> >>>>>> the presence of nonlinear history, without affecting performance
> >>>>>> too badly.
> >>>>>
> >>>>> Ah, that is too bad because I think it would really useful.
> >>>>> Image browsing a drivers history in the linux kernel. Then it would be
> >>>>> really nice to see what changes/bug fixes went into what release.
> >>>>
> >>>> First, you can help with the first issue even if you can't help with
> >>>> the coding itself.
> >>>
> >>> I like the gitk way of showing tags, won't that work in gitweb too?
> >>
> >> Err... "gitk" shows tags, but so does 'shortlog' and 'log' view in
> >> gitweb. The 'history' view in gitweb doesn't show intermediate tags,
> >> but neither does "gitk -- <path>".
> >
> > I know, I just meant the yellow note with tag name in it, how tags
> > are displayed. When they are display is another matter :)
>
> When those yellow notes with tag name are displayed beside commit
> subject it means that this commit is referenced by given tag (i.e.
> <this tag>^{commit} = <this commit>).
>
> We have to distinguish situation where tag is between commits, and
> tag points to commit.
Why? I just want to know if a commit is included or not in the tag.
When a tag is formally between commits, just display the
tag with the commit line below.
Jocke
prev parent reply other threads:[~2010-09-13 5:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-11 14:37 gitweb: please show tags file history browsing Tjernlund
2010-09-11 17:40 ` Jakub Narebski
2010-09-12 9:27 ` Tjernlund
2010-09-12 10:19 ` Jakub Narebski
2010-09-12 13:11 ` Tjernlund
2010-09-12 15:19 ` Jakub Narebski
2010-09-12 16:12 ` Tjernlund
2010-09-12 18:20 ` Jakub Narebski
2010-09-13 5:42 ` Tjernlund [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001601cb5306$6a7d8030$3f788090$@se' \
--to=tjernlund@tjernlund.se \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).