git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Jonas Bang" <email@jonasbang.dk>
To: "'Junio C Hamano'" <gitster@pobox.com>
Cc: <git@vger.kernel.org>
Subject: RE: Git feature request: Option to force Git to abort a checkout if working directory is dirty (i.e. disregarding the check for conflicts)
Date: Tue, 1 Apr 2014 19:57:26 +0200	[thread overview]
Message-ID: <002a01cf4dd3$d88c8640$89a592c0$@jonasbang.dk> (raw)
In-Reply-To: <xmqqha6e8f67.fsf@gitster.dls.corp.google.com>

> >> For some people it is also a norm to keep files that have been
> >> modified from HEAD and/or index without committing for a long time
> >> (e.g. earlier, Linus said that the version in Makefile is updated and
> >> kept modified in the working tree long before a new release is
> >> committed with that change).  The default behaviour would cover their
> >> use case so your proposal would not hurt them, but I wonder if there
> >> are things you could do to help them as well, perhaps by allowing
> >> this new configuration to express something like "local changes in
these
> paths are except from this new check".
> >
> > Yes, those people would probably use the default 'false' behavior as
> > it is already. If they however would like to use e.g. the 'true' or
> > 'include-untracked' setting as a configuration variable, then they can
> > use the command line option 'false' if they wish to do a 'git
> > checkout' even with modified files in the working tree.
> 
> So in short, you are saying that "The added code necessary to implement
this
> feature will not help them in any way, it is just that we will make sure
it does
> not hurt them".

I didn't realize they needed help. Based on what you describe it seems that
they are quite happy about their current workmode. The feature request I'm
proposing is to aid a different workmode used by a different group of users.

I did try to give it some thought to figure out if it would be possible to
address also your mentioned users workmode, but it didn't seem straight
forward to solve in combination with my feature request, and the solution
wouldn't end up being as simple. However I did already manage to include
proposals on how to address your other comments, I believe.

I have focused primarily on proposing a feature request which is as simple
as possible and which addresses an issue with a workmode for a group of
users, and which in the same time doesn't "hurt" others.

What are your thoughts on that part?
How and who to decide if this is a reasonable feature request to accept?

  reply	other threads:[~2014-04-01 17:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-27 16:15 Git feature request: Option to force Git to abort a checkout if working directory is dirty (i.e. disregarding the check for conflicts) Jonas Bang
2014-03-27 17:46 ` Junio C Hamano
2014-03-29 11:49   ` Jonas Bang
2014-03-31 17:13     ` Junio C Hamano
2014-04-01 17:57       ` Jonas Bang [this message]
2014-04-02 17:55         ` Junio C Hamano
2014-04-03 18:42           ` Jonas Bang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='002a01cf4dd3$d88c8640$89a592c0$@jonasbang.dk' \
    --to=email@jonasbang.dk \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).