From: "Joachim Schmitz" <jojo@schmitz-digital.de>
To: "'Junio C Hamano'" <gitster@pobox.com>
Cc: <git@vger.kernel.org>, "'Johannes Sixt'" <j6t@kdbg.org>
Subject: RE: [PATCH 1/2] Support for setitimer() on platforms lacking it
Date: Tue, 4 Sep 2012 23:47:56 +0200 [thread overview]
Message-ID: <002c01cd8ae6$f23d7ec0$d6b87c40$@schmitz-digital.de> (raw)
In-Reply-To: <7vobllaami.fsf@alter.siamese.dyndns.org>
> From: Junio C Hamano [mailto:gitster@pobox.com]
> Sent: Tuesday, September 04, 2012 8:47 PM
> To: Joachim Schmitz
> Cc: git@vger.kernel.org; 'Johannes Sixt'
> Subject: Re: [PATCH 1/2] Support for setitimer() on platforms lacking it
>
> Junio C Hamano <gitster@pobox.com> writes:
>
> > "Joachim Schmitz" <jojo@schmitz-digital.de> writes:
> >
> >>> Only with the observation of "clone", I cannot tell if your timer is
> >>> working. You can try repacking the test repository you created by
> >>> your earlier "git clone" with "git repack -a -d -f" and see what
> >>> happens.
> >>
> >> It does update the counter too.
> >
> > Yeah, that was not a very good way to diagnose it.
> >
> > You see the progress from pack-objects (which is the underlying
> > machinery "git repack" uses) only because it knows how many objects
> > it is going to pack, and it updates the progress meter for every
> > per-cent progress it makes, without any help from the timer
> > interrupt.
>
> I think the "Counting objects: $number" phase is purely driven by
> the timer, as there is no way to say "we are done X per-cent so
> far".
>
> Doesn't your repack show "Counting objects: " with a number once,
> pause forever and then show "Counting objects: $number, done."?
Yes, only once, when it is done
$ ./git repack -a -d -f
warning: no threads support, ignoring --threads
Counting objects: 140302, done.
Compressing objects: 1% (1385/138407)
next prev parent reply other threads:[~2012-09-04 21:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-24 10:39 [PATCH 1/2] Support for setitimer() on platforms lacking it Joachim Schmitz
2012-08-28 20:15 ` Junio C Hamano
2012-08-30 16:40 ` Joachim Schmitz
2012-08-30 17:13 ` Junio C Hamano
2012-08-30 17:22 ` Joachim Schmitz
2012-09-01 9:50 ` Joachim Schmitz
2012-09-02 20:43 ` Junio C Hamano
2012-09-03 9:31 ` Joachim Schmitz
2012-09-03 18:15 ` Johannes Sixt
2012-09-03 18:57 ` Junio C Hamano
2012-09-03 19:03 ` Junio C Hamano
2012-09-03 20:05 ` Joachim Schmitz
2012-09-04 16:58 ` Junio C Hamano
2012-09-04 17:23 ` Joachim Schmitz
2012-09-04 18:28 ` Junio C Hamano
2012-09-04 18:47 ` Junio C Hamano
2012-09-04 21:47 ` Joachim Schmitz [this message]
2012-09-04 22:44 ` Junio C Hamano
2012-09-05 9:59 ` Joachim Schmitz
2012-09-04 18:48 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002c01cd8ae6$f23d7ec0$d6b87c40$@schmitz-digital.de' \
--to=jojo@schmitz-digital.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).