git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Randall S. Becker" <rsbecker@nexbridge.com>
To: "'git mailing list'" <git@vger.kernel.org>
Subject: [Bug] NO_INTPTR_T not being honoured in compat/regex/regcomp.c
Date: Mon, 1 Jan 2018 16:21:25 -0500	[thread overview]
Message-ID: <004701d38346$7dd4be00$797e3a00$@nexbridge.com> (raw)

I'm looking for the proper approach for dealing with the following situation
in 2.8.5:
* I have defined NO_INTPTR_T = UnfortunatelyYes in config.mak.uname for my
platform. The c99 compiler I have does not define it.
* The code compiles except for compat/regex/regcomp.c - not sure why this is
being used since I have also *not* defined NO_REGEX because regex is sane
here.
* If I include git-compat-util.h, where intptr_t is defined, in this
compile, loads of other compile problems result.
* To get around the compile problem, I have wrapped the definition of
intptr_t as follows, temporarily, duplicating content from git-compat-util.h
        #include <stdint.h>
        #if defined __TANDEM
        #ifdef NO_INTPTR_T
        typedef long intptr_t;
        typedef unsigned long uintptr_t;
        #endif
        #endif

So the question now is how best to handle this long term. I'm slowly porting
up to 2.16 - hoping a week or two until I get there with the mods required
and running tests and all. It does not look like the issue of intptr_t is
subsequently resolved in regcomp.c (other than #include <stdint.h> being
removed), so this is going to continue to haunt me as a problem. There are
loads of ways of dealing with it, but I'd like to fix this in a way that
best follows the team's standards. So...

1. I'd rather not worry about regcomp.c, but don't know why it's still
somehow required. 
2. git-compat-util.h is pretty heavy just for intptr_t in this module.
Refactoring might be an option.

Thanks,
Randall

-- Brief whoami: NonStop&UNIX developer since approximately
UNIX(421664400)/NonStop(211288444200000000)
-- In my real life, I talk too much.



             reply	other threads:[~2018-01-01 21:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-01 21:21 Randall S. Becker [this message]
2018-01-01 21:51 ` [Bug] NO_INTPTR_T not being honoured in compat/regex/regcomp.c Eric Sunshine
2018-01-01 22:12   ` Randall S. Becker
2018-01-02 23:08   ` Randall S. Becker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='004701d38346$7dd4be00$797e3a00$@nexbridge.com' \
    --to=rsbecker@nexbridge.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).