From: "Randall S. Becker" <rsbecker@nexbridge.com>
To: "'Jeff King'" <peff@peff.net>, "'Junio C Hamano'" <gitster@pobox.com>
Cc: "'Ed Avis'" <eda@waniasset.com>, <git@vger.kernel.org>
Subject: RE: Suggestion: make git checkout safer
Date: Wed, 3 Jun 2015 15:24:12 -0400 [thread overview]
Message-ID: <006401d09e32$dfc29890$9f47c9b0$@nexbridge.com> (raw)
In-Reply-To: <20150603190616.GA28488@peff.net>
On June 3, 2015 3:06 PM Jeff King wrote:
> On Wed, Jun 03, 2015 at 10:32:40AM -0700, Junio C Hamano wrote:
> > "git checkout $paths" (and you can give "." for $paths to mean
> > "everything") is akin to "cp -R $elsewhere/$path ." to restore the
> > working tree copies from somewhere else.
> >
> > "Ouch, 'git checkout .' overwrote what was in my working tree" is
> > exactly the same kind of confusion as "I ran 'cp -r ../saved .' and it
> > overwrote everything". As you said in your initial response, that is
> > what the command is meant for.
> >
> > What does that similar command outside world, "cp", have for "more
> > safety"? 'cp -i' asks if the user wants to overwrite a file for each
> > path; perhaps a behaviour similar to that was the original poster
> > wanted to see?
>
> Yeah, I'd say "cp -i" is the closest thing. I don't have a problem with adding that,
> but I'd really hate for it to be the default (just as I find distros which "alias
> rm='rm -i" annoying).
Brainstorming a few compromises:
or some such config option to turn on behaviour like this:
core.checkout=-i
or some such thing where if there are strictly more than m files being touched and strictly less than n files to act accordingly - a threshold concept:
core.checkout_warn_upperlimit=n # default to 0
core.checkout_warn_lowerlimit=m # default to 0
or in a more gross fashion provide a pre-checkout hook to do all the work of prompting/control of the situation.
Personally I'm happy with the defaults as they are (and was not a fan of defaulting rm -i or cp -i either) but I can see the point and have had diffuse whines from my team on the checkout subject, which is why I'm commenting.
next prev parent reply other threads:[~2015-06-03 19:24 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-03 8:50 Suggestion: make git checkout safer Ed Avis
2015-06-03 9:06 ` Jeff King
2015-06-03 9:21 ` Ed Avis
2015-06-03 9:35 ` Jeff King
2015-06-03 9:55 ` Ed Avis
2015-06-03 17:35 ` Junio C Hamano
2015-06-03 17:49 ` Randall S. Becker
2015-06-03 18:11 ` Junio C Hamano
2015-06-03 18:18 ` Randall S. Becker
2015-06-03 18:14 ` Stefan Beller
2015-06-04 10:47 ` Ed Avis
2015-06-04 11:02 ` Ed Avis
2015-06-03 19:26 ` Torsten Bögershausen
2015-06-03 19:47 ` Kevin Daudt
2015-06-04 11:00 ` Ed Avis
2015-06-04 20:14 ` Torsten Bögershausen
2015-06-05 9:32 ` Ed Avis
2015-06-05 10:49 ` Duy Nguyen
2015-06-05 17:44 ` Eric Sunshine
2015-06-05 18:03 ` Junio C Hamano
2015-06-05 18:46 ` Ed Avis
2015-06-05 18:37 ` Eric Sunshine
2015-06-03 20:12 ` Philip Oakley
2015-06-03 17:32 ` Junio C Hamano
2015-06-03 19:06 ` Jeff King
2015-06-03 19:24 ` Randall S. Becker [this message]
2015-06-03 21:29 ` Junio C Hamano
2015-06-04 9:01 ` John Szakmeister
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='006401d09e32$dfc29890$9f47c9b0$@nexbridge.com' \
--to=rsbecker@nexbridge.com \
--cc=eda@waniasset.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).