git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: <rsbecker@nexbridge.com>
To: "'D. Ben Knoble'" <ben.knoble@gmail.com>
Cc: "'SZEDER Gábor'" <szeder.dev@gmail.com>, git@vger.kernel.org
Subject: RE: [BUGS] Git v2.51.2 on NonStop
Date: Thu, 30 Oct 2025 10:59:34 -0400	[thread overview]
Message-ID: <006e01dc49ad$d12f9a80$738ecf80$@nexbridge.com> (raw)
In-Reply-To: <CALnO6CAYmtDmfk36nX6TCCaV2c=8J0BXv9eN+L=j1PU=gPmJUQ@mail.gmail.com>

On October 30, 2025 9:53 AM, D. Ben Knoble wrote:
>On Wed, Oct 29, 2025 at 8:25 PM <rsbecker@nexbridge.com> wrote:
>>
>> What appears to be happening is that the Make environment is only
>> using SHELL=/bin/bash for the outer processing but not the inner
>> #!/bin/sh of t7900. The system is using /bin/sh as specified, which
>> uses ksh, not bash, which is the trace above. When I run the
>> individual tests with bash, the error reported goes away. The problem
>> is, with my version of Gnu Make, 4.1.2, the SHELL variable is only
>> being replaced for the command processing of each recipe. Once the
>> system loader sees the shebang of #!/bin/sh, /bin/sh is used as
>> requested, and fails out. This means that I have to remember to manually run
>each test that fails with bash instead of the default. It is frustrating and now adds
>hours to my manual evaluation of the CI/CD results.
>>
>> The trace above is from sh, not bash because of this.
>>
>> With Frustration,
>> Randall
>
>Is this the only ksh-induced failure? And if so, what is inducing the failure—is it
>something the test library can work around, or is the system {k,}sh not behaving
>portably here?
>
>My preference would be towards making your setup "just work" assuming there's
>not a clear contradiction of portable standards somewhere.

I think there were other ksh issues, mostly the SHELL= setting in make. I will report
others on a per test case basis when they come. The SHELL_PATH= definitely is
using bash, so that fix suggested by Peff is working out nicely.

Regards,
Randall


  reply	other threads:[~2025-10-30 14:59 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-27 15:56 [ANNOUNCE] Git v2.51.2 Junio C Hamano
2025-10-28 17:40 ` [BUGS] Git v2.51.2 on NonStop rsbecker
2025-10-29 22:28   ` SZEDER Gábor
2025-10-29 22:41     ` rsbecker
2025-10-29 23:18       ` SZEDER Gábor
2025-10-30  0:24         ` rsbecker
2025-10-30  2:53           ` Jeff King
2025-10-30 13:52           ` D. Ben Knoble
2025-10-30 14:59             ` rsbecker [this message]
2025-10-30 21:23             ` brian m. carlson
2025-10-30 15:15   ` Kristoffer Haugsbakk
2025-10-30 16:02     ` rsbecker
2025-10-30 19:42     ` Junio C Hamano
2025-10-30 20:25       ` Kristoffer Haugsbakk
2025-10-30 21:46         ` [BUGS] Git v2.51.2 on NonStop5 rsbecker
2025-10-30 22:30           ` SZEDER Gábor
2025-10-31  1:02             ` rsbecker
2025-10-31 14:09           ` rsbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='006e01dc49ad$d12f9a80$738ecf80$@nexbridge.com' \
    --to=rsbecker@nexbridge.com \
    --cc=ben.knoble@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=szeder.dev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).