From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Randall S. Becker" Subject: RE: t5570 - not cloned error Date: Thu, 7 May 2015 14:24:46 -0400 Message-ID: <009401d088f3$18d53200$4a7f9600$@nexbridge.com> References: <013701d08769$a5bbab80$f1330280$@nexbridge.com> <017401d08782$24d6f5b0$6e84e110$@nexbridge.com> <20150505225521.GB18817@peff.net> <019401d08796$0bf9f880$23ede980$@nexbridge.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Cc: "'Junio C Hamano'" , , "'Joachim Schmitz'" To: "'Jeff King'" X-From: git-owner@vger.kernel.org Thu May 07 20:25:04 2015 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YqQTm-0004Oz-Rj for gcvg-git-2@plane.gmane.org; Thu, 07 May 2015 20:25:03 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751593AbbEGSY6 (ORCPT ); Thu, 7 May 2015 14:24:58 -0400 Received: from elephants.elehost.com ([216.66.27.132]:51387 "EHLO elephants.elehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751061AbbEGSY5 convert rfc822-to-8bit (ORCPT ); Thu, 7 May 2015 14:24:57 -0400 X-Virus-Scanned: amavisd-new at elehost.com Received: from pangea (CPE0023eb577e25-CM602ad06c91a7.cpe.net.cable.rogers.com [99.237.128.150]) (authenticated bits=0) by elephants.elehost.com (8.14.9/8.14.9) with ESMTP id t47IOnP1023224 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 7 May 2015 14:24:49 -0400 (EDT) (envelope-from rsbecker@nexbridge.com) In-Reply-To: <019401d08796$0bf9f880$23ede980$@nexbridge.com> X-Mailer: Microsoft Outlook 15.0 Thread-Index: AQGTGMzZfqjkVUQ9RxorcLBPHDSlfQLCdjq/AzQCqbwCby4QeAHeXSswnZeez5A= Content-Language: en-ca Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On May 5, 2015 8:46 PM, I wrote in my haste: > On May 5, 2015 6:55 PM Jeff King wrote: > > On Tue, May 05, 2015 at 06:23:41PM -0400, Randall S. Becker wrote: > > > On May 5, 2015 6:01 PM Junio C Hamano wrote: > > > > "Randall S. Becker" writes: > > > > > We definitely have an issue with localhost. When forcing the DNS > > > resolver to > > > > > return 127.0.0.1, we pass 1-16 then 17 fails as I expected to happen > > > based > > > > > on my DNS futzing. Heads up that this test is not-surprisingly sensitive > > > to > > > > > DNS problems. My environment is still in a messy state where I can > > > reproduce > > > > > the original problem so it might be a useful moment for me to find a way > > > to > > > > > modify the test script to harden it. Any suggestion on that score > > > > > (as in where and roughly how it might be made more reliable)? > > > > > > > > I do not think this counts as a useful "suggestion", but is this > > > > "resolver does not work for local as expected" case even worth > > > > protecting our tests against? > > > > > > I see your point, but after having spent "way too much time" away from the > > > $DAYJOB tracking this down, I was hoping to catch the root cause earlier > > > next time. Perhaps adding a test step validating that localhost comes back > > > with a reasonable value - whatever that may be in context. I'm just not sure > > > what the test really needs at its heart to run properly - obviously the IP > > > address of the system as visible in our DMZ is not working for the test. > > > > I'm having trouble even understanding who is looking up "localhost" > > here. All of the git-daemon tests should be directly using 127.0.0.1 in > > the URLs (i.e., what is in $GIT_DAEMON_URL). If that is a problem, I > > think you might be able to parameterize the way we set up > > $GIT_DAEMON_URL (and how we invoked git-daemon; see lib-git- > daemon.sh). > > > > In the interpolation tests, we do use the string "localhost" but we > > should never do a lookup on it. We set an environment variable that > > tells the git client to _tell_ the server we looked up localhost, but we > > should still be accessing it as 127.0.0.1. > > > > So I'm confused about what the actual problem is, or why the test cares > > about resolving "localhost" in the first place. > > That gives me a pretty good idea of where to start looking. I will first hunt > down the resolution and go from there. Stay tuned - it may be a day or two > before I have a chance to do more than a cursory debug. I found the root cause, being that the multi-IP stack configuration on this platform is not being passed correctly through bash to the shell that make starts when running tests. When running the test under ksh, which has a deeper port, the test behaves correctly. As it turns out, this is a platform-specific issue with our bash port. This is not git's issue at all, nor the DNS resolver configuration (although I did find an independent problem there). Sorry to be a bother. Cheers, Randall