From: "Randall S. Becker" <rsbecker@nexbridge.com>
To: "'Jonathan Nieder'" <jrnieder@gmail.com>
Cc: <git@vger.kernel.org>, "'Todd Zullinger'" <tmz@pobox.com>,
"'Jeff King'" <peff@peff.net>
Subject: RE: [Suggestion] Add Skip for t9020
Date: Thu, 21 Feb 2019 21:46:25 -0500 [thread overview]
Message-ID: <00ae01d4ca58$d0d8d0f0$728a72d0$@nexbridge.com> (raw)
In-Reply-To: <20190222004659.GA167507@google.com>
On February 21, 2019 19:47, Jonathan Nieder wrote:
> Randall S. Becker wrote:
>
> > While this is a bit of a hack, it might be useful for skipping t9020
> > in environments where the svn.remote package is not installed. I can
> > make this into a patch if this style is reasonable - guessing probably
> > not and that the REMOTE_SVN test should go elsewhere if it is called
that.
> >
> > diff --git a/t/t9020-remote-svn.sh b/t/t9020-remote-svn.sh index
> > 6fca08e5e3..31edf99371 100755
> > --- a/t/t9020-remote-svn.sh
> > +++ b/t/t9020-remote-svn.sh
> > @@ -12,6 +12,12 @@ then
> > test_done
> > fi
> >
> > +python -c "import svn.remote" 2>/dev/null >/dev/null if [ $? -eq 0 ];
> > +then
> > + test_set_prereq REMOTE_SVN
> > +fi
> > +if ! test_have_prereq REMOTE_SVN
> > +then
> > + skip_all='skipping remote-svn tests, python svn.remote not
> > available'
> > + test_done
> > +fi
>
> Interesting. Where do we use the svn.remote package? I did a quick grep
> and didn't find any instances.
Well, this was the remote svn test, so I figured I would be specific. We
don't have the svn package either so could restrict to that.
> Do you have output from running "./t9020-remote-svn.sh -v -i"?
Initialized empty Git repository in /home/git/git/t/trash
directory.t9020-remote-svn/.git/
expecting success:
init_git &&
git fetch svnsim &&
test_cmp .git/refs/svn/svnsim/master .git/refs/remotes/svnsim/master
&&
cp .git/refs/remotes/svnsim/master master.good
Initialized empty Git repository in /home/git/git/t/trash
directory.t9020-remote-svn/.git/
fatal: error reading from fast-import: Resource temporarily unavailable
progress Imported commit 1.
fatal: error while running fast-import
not ok 1 - simple fetch
#
# init_git &&
# git fetch svnsim &&
# test_cmp .git/refs/svn/svnsim/master
.git/refs/remotes/svnsim/master &&
# cp .git/refs/remotes/svnsim/master master.good
#
prev parent reply other threads:[~2019-02-22 2:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 20:28 [Suggestion] Add Skip for t9020 Randall S. Becker
2019-02-21 20:58 ` Todd Zullinger
2019-02-22 15:30 ` Jeff King
2019-02-22 0:46 ` Jonathan Nieder
2019-02-22 2:46 ` Randall S. Becker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00ae01d4ca58$d0d8d0f0$728a72d0$@nexbridge.com' \
--to=rsbecker@nexbridge.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
--cc=tmz@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).