Git development
 help / color / mirror / Atom feed
From: "Ramsay Jones" <ramsay@ramsay1.demon.co.uk>
To: <git@vger.kernel.org>
Subject: [PATCH 7/10] Fix header breakage due to redefining PATH_MAX.
Date: Wed, 2 Aug 2006 02:03:41 +0100	[thread overview]
Message-ID: <00ba01c6b5cf$7e9b4300$c47eedc1@ramsay1.demon.co.uk> (raw)

[-- Attachment #1: Type: text/plain, Size: 765 bytes --]

The header builtin.h was, incorrectly, redefining PATH_MAX which
causes a header order dependency in builtin-write-tree.c.  The fix
is to simply include <limits.h> directly to obtain the correct
definition of PATH_MAX.

Signed-off-by: Ramsay Allan Jones <ramsay@ramsay1.demon.co.uk>
---
Note that on Linux 2.2.14, PATH_MAX is define to be 4095.
(Solaris, Mac OSX, *BSD define it as 1024)

 builtin.h |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)

diff --git a/builtin.h b/builtin.h
index f12d5e6..7bfff11 100644
--- a/builtin.h
+++ b/builtin.h
@@ -2,10 +2,7 @@ #ifndef BUILTIN_H
 #define BUILTIN_H
 
 #include <stdio.h>
-
-#ifndef PATH_MAX
-# define PATH_MAX 4096
-#endif
+#include <limits.h>
 
 extern const char git_version_string[];
 
-- 
1.4.1

[-- Attachment #2: P0007.TXT --]
[-- Type: text/plain, Size: 898 bytes --]

From 14324992ff3a9b43c3ac9c869ef40cf59eeac245 Mon Sep 17 00:00:00 2001
From: Ramsay Allan Jones <ramsay@ramsay1.demon.co.uk>
Date: Sun, 30 Jul 2006 17:00:40 +0100
Subject: [PATCH 7/10] Fix header breakage due to redefining PATH_MAX.

The header builtin.h was, incorrectly, redefining PATH_MAX which
causes a header order dependency in builtin-write-tree.c.  The fix
is to simply include <limits.h> directly to obtain the correct
definition of PATH_MAX.

Signed-off-by: Ramsay Allan Jones <ramsay@ramsay1.demon.co.uk>
---
 builtin.h |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)

diff --git a/builtin.h b/builtin.h
index f12d5e6..7bfff11 100644
--- a/builtin.h
+++ b/builtin.h
@@ -2,10 +2,7 @@ #ifndef BUILTIN_H
 #define BUILTIN_H
 
 #include <stdio.h>
-
-#ifndef PATH_MAX
-# define PATH_MAX 4096
-#endif
+#include <limits.h>
 
 extern const char git_version_string[];
 
-- 
1.4.1


                 reply	other threads:[~2006-08-02  1:03 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='00ba01c6b5cf$7e9b4300$c47eedc1@ramsay1.demon.co.uk' \
    --to=ramsay@ramsay1.demon.co.uk \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox