From: <rsbecker@nexbridge.com>
To: "'Junio C Hamano'" <gitster@pobox.com>
Cc: "'brian m. carlson'" <sandals@crustytoothpaste.net>,
<git@vger.kernel.org>
Subject: RE: [Test Breakage 2.46.0-rc0] Test t0021.35 fails on NonStop
Date: Mon, 15 Jul 2024 13:39:25 -0400 [thread overview]
Message-ID: <00c001dad6dd$f336c3e0$d9a44ba0$@nexbridge.com> (raw)
In-Reply-To: <xmqqh6cq4ngc.fsf@gitster.g>
On Monday, July 15, 2024 12:42 PM, Junio C Hamano wrote:
><rsbecker@nexbridge.com> writes:
>
>> What is strange is that when running on NonStop using ksh, t0000.1 has
>> never failed. I think the situation is subtly different from what we are
solving.
>> My take is that there is a difference in the local vs. non-local
>> variable set semantic, rather than just accepting the keyword. I would
>> propose that we need a more comprehensive local test to verify the
>> actual expected semantics rather than just testing the syntax.
>
>It is possible that I may be misreading that first test, but as far as I
can tell, it is
>testing not just the syntax but tests how the variables declared "local"
behaves and
>should notice if they are not localized. It checks that "local"
assignments in
>try_local_xy does take effect, and (more importantly) after try_local_xy
returns, the
>original values are restored.
>
>As I speculated earlier in an earlier message, the breakage you reported
may have to
>do with interaction between "local" and use of a subshell, and perhaps we
can also
>check that pattern in the test.
That is that I am also suggesting but did not say it as precisely. Thanks.
next prev parent reply other threads:[~2024-07-15 17:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-13 16:38 [Test Breakage 2.46.0-rc0] Test t0021.35 fails on NonStop rsbecker
2024-07-14 2:53 ` Junio C Hamano
2024-07-14 13:29 ` rsbecker
2024-07-14 17:00 ` Junio C Hamano
2024-07-14 17:29 ` rsbecker
2024-07-14 18:15 ` brian m. carlson
2024-07-14 18:28 ` rsbecker
2024-07-14 22:01 ` brian m. carlson
2024-07-14 22:14 ` rsbecker
2024-07-15 15:20 ` Junio C Hamano
2024-07-15 15:32 ` rsbecker
2024-07-15 16:41 ` Junio C Hamano
2024-07-15 17:39 ` rsbecker [this message]
2024-07-15 18:33 ` Junio C Hamano
2024-07-15 19:03 ` rsbecker
2024-07-15 15:05 ` Junio C Hamano
2024-07-14 21:27 ` Eric Sunshine
2024-07-14 13:58 ` rsbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00c001dad6dd$f336c3e0$d9a44ba0$@nexbridge.com' \
--to=rsbecker@nexbridge.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).