From: <rsbecker@nexbridge.com>
To: "'Jeff King'" <peff@peff.net>,
"'Eric Sunshine'" <sunshine@sunshineco.com>
Cc: "'Git List'" <git@vger.kernel.org>
Subject: RE: Request for Help - Too many perl arguments as of 2.43.0-rc0
Date: Sat, 4 Nov 2023 10:55:47 -0400 [thread overview]
Message-ID: <00e301da0f2f$024f9360$06eeba20$@nexbridge.com> (raw)
In-Reply-To: <20231104134915.GA1492953@coredump.intra.peff.net>
On November 4, 2023 9:49 AM, Jeff King wrote:
>On Sat, Nov 04, 2023 at 02:36:48AM -0400, Eric Sunshine wrote:
>
>> I don't see an urgent need for it. Unlike the actual tests themselves
>> run by `make test` which may catch platform-specific problems in Git
>> itself, the purpose of the "linting" checks is not to catch
>> platform-specific problems, but rather to help test authors by
>> identifying mistakes in the tests which might make them fragile. So,
>> disabling linting on a particular platform isn't going to cause `make
>> test` to miss some important Git problem specific to that platform.
>
>Hmm. With compilation, we split the audience of "developers" vs "people who just
>want to build the program", and we crank up the number and severity of warning
>checks for the former. We could do the same here for tests. I.e., turn off test linting
>by default and re-enable it for DEVELOPER=1.
>
>OTOH, this is the first time I think I've seen the linting cause a problem (whereas
>unexpected compile warnings are much more likely, as we are depending on the
>system compiler's behavior).
>
>So consider it an idle thought for discussion, and not necessarily a proposal. ;)
In my case, I am building git for users of the platform (a.k.a. mostly a packager), although I'm hoping to be more involved in contributions soon. This involves build + full test under multiple situations on the NonStop platform.
--Randall
next prev parent reply other threads:[~2023-11-04 14:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-03 19:03 Request for Help - Too many perl arguments as of 2.43.0-rc0 rsbecker
2023-11-03 20:52 ` Eric Sunshine
2023-11-03 21:30 ` rsbecker
2023-11-03 21:50 ` Eric Sunshine
2023-11-03 22:04 ` rsbecker
2023-11-04 6:36 ` Eric Sunshine
2023-11-04 7:59 ` Junio C Hamano
2023-11-04 23:50 ` Eric Sunshine
2023-11-04 13:49 ` Jeff King
2023-11-04 14:55 ` rsbecker [this message]
2023-11-05 0:11 ` Eric Sunshine
2023-11-05 5:34 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00e301da0f2f$024f9360$06eeba20$@nexbridge.com' \
--to=rsbecker@nexbridge.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).