RE: [BUG] Re: Git 2.35.0-rc0

[<rsbecker@nexbridge.com>]

On January 10, 2022 10:52 PM, Taylor Blau wrote:
> On January 10, 2022 10:00 PM, Taylor Blau wrote:
> > On Mon, Jan 10, 2022 at 09:57:57PM -0500, rsbecker@nexbridge.com
> > wrote:
> > > > If your system doesn't have a modern-ish zlib, you may try
> > > > building with that knob, or upgrading your system's copy of zlib.
> > > > And if NonStop doesn't have a modern zlib available at all, we
> > > > should modify the NonStop section of config.mak.uname.
> > >
> > > There is no provision in reftable/block.c to avoid using
> > > uncompress2, so the knob will not help. Our zlibc is not that recent
> > > (as in it does not have uncompress2) and we cannot make the 2.35.0
> > > timeframe to upgrade it. The current zlib seems to require gcc and
> > > is very difficult to port at this stage. This is a blocker situation.
> >
> > NO_UNCOMPRESS2 does not avoid calling uncompress2, but instead
> > compiles a copy-and-pasted implementation in compat/ so that the function
> is available.
> >
> > Looking through it, I can't imagine that it wouldn't compile just fine
> > even on NonStop.
> >
> > Have you tried building with NO_UNCOMPRESS2?
> 
> The patch for NonStop to make this compile is as follows. Test is running - will
> be 2 days:
> 
> diff --git a/config.mak.uname b/config.mak.uname index
> a3a779327f..9b3e9bff5f 100644
> --- a/config.mak.uname
> +++ b/config.mak.uname
> @@ -576,6 +576,7 @@ ifeq ($(uname_S),NONSTOP_KERNEL)
>         NO_SETENV = YesPlease
>         NO_UNSETENV = YesPlease
>         NO_MKDTEMP = YesPlease
> +       NO_UNCOMPRESS2 = YesPlease
>         # Currently libiconv-1.9.1.
>         OLD_ICONV = UnfortunatelyYes
>         NO_REGEX = NeedsStartEnd
> 
> Could we get that into rc1?

The above is working. We're at t2015 right now. Much relieved.
--Randall