From: <rsbecker@nexbridge.com>
To: <git@vger.kernel.org>
Subject: [Bug] wrapper.c uses unportable unsetenv
Date: Fri, 29 Oct 2021 16:14:17 -0400 [thread overview]
Message-ID: <012301d7cd01$90428960$b0c79c20$@nexbridge.com> (raw)
The unsetenv()/setenv(overwrite) calls are not 100% portable - as in not on
all POSIX implementations. It breaks the build on some of the NonStop
platforms. This will change in a year or two but I really don't want to fall
behind on git releases.
This was introduced at 3540c71 but I was on vacation when it happened so did
not catch it during reviews - my apologies for that.
Is it critical that this be called or can we #ifdef it away if it isn't
supported for a build? The #if is exactly this:
wrapper.c@150
+ #if (_TANDEM_ARCH_ > 3 || (_TANDEM_ARCH_ == 3 && __L_Series_RVU >= 2010))
if (setenv(name, value, overwrite))
die_errno(_("could not setenv '%s'"), name ? name :
"(null)");
+ #endif
wrapper.c@154
+ #if (_TANDEM_ARCH_ > 3 || (_TANDEM_ARCH_ == 3 && __L_Series_RVU >= 2010))
if (!unsetenv(name))
die_errno(_("could not unsetenv '%s'"), name ? name :
"(null)");
+ #endif
-Randall
next reply other threads:[~2021-10-29 20:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-29 20:14 rsbecker [this message]
2021-10-29 20:35 ` [Bug] wrapper.c uses unportable unsetenv Junio C Hamano
2021-10-29 20:49 ` rsbecker
2021-10-29 21:10 ` rsbecker
2021-10-29 21:42 ` Junio C Hamano
2021-10-29 21:50 ` Johannes Schindelin
2021-10-29 21:57 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='012301d7cd01$90428960$b0c79c20$@nexbridge.com' \
--to=rsbecker@nexbridge.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).