From: <rsbecker@nexbridge.com>
To: <rsbecker@nexbridge.com>, "'Junio C Hamano'" <gitster@pobox.com>
Cc: <git@vger.kernel.org>
Subject: RE: [Bug] wrapper.c uses unportable unsetenv
Date: Fri, 29 Oct 2021 17:10:44 -0400 [thread overview]
Message-ID: <013a01d7cd09$72d91cb0$588b5610$@nexbridge.com> (raw)
In-Reply-To: <013501d7cd06$8c8281e0$a58785a0$@nexbridge.com>
On October 29, 2021 4:50 PM, I wrote:
> To: 'Junio C Hamano' <gitster@pobox.com>
> Cc: git@vger.kernel.org
> Subject: RE: [Bug] wrapper.c uses unportable unsetenv
>
> On October 29, 2021 4:35 PM, Junio C Hamano:
> > <rsbecker@nexbridge.com> writes:
> >
<snip>
> > There are compat/setenv.c and compat/unsetenv.c to be used when
> > NO_SETENV and NO_UNSETENV are defined. Is that how you built your Git
> > earlier since 2007, perhaps?
>
> We have defined NO_SETENV and NO_UNSETENV since I have been maintaining
> it, so I don't get how we are getting into this situation. I was planning
on
> removing NO_SETENV when the OS caught up for that on our minimum support
> builds next year. NO_UNSETENV needs to stick around for bit longer. The
> setenv() code is actually fine. It is unsetenv() that is causing problems.
> Should not git-compat-util.h be included in wrapper.c so that we reference
> gitunsetenv?
The actual issue is this:
if (!unsetenv(name))
^
"/home/ituglib/randall/git/wrapper.c", line 156: error(134): expression
must have arithmetic or pointer type
This is with NO_UNSETENV = YesPlease. It makes no sense to me why this isn't
compiling.
next prev parent reply other threads:[~2021-10-29 21:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-29 20:14 [Bug] wrapper.c uses unportable unsetenv rsbecker
2021-10-29 20:35 ` Junio C Hamano
2021-10-29 20:49 ` rsbecker
2021-10-29 21:10 ` rsbecker [this message]
2021-10-29 21:42 ` Junio C Hamano
2021-10-29 21:50 ` Johannes Schindelin
2021-10-29 21:57 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='013a01d7cd09$72d91cb0$588b5610$@nexbridge.com' \
--to=rsbecker@nexbridge.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).