From: <rsbecker@nexbridge.com>
To: "'Junio C Hamano'" <gitster@pobox.com>
Cc: "'Jeff King'" <peff@peff.net>,
"'Carlo Marcelo Arenas Belón'" <carenas@gmail.com>,
git@vger.kernel.org, avarab@gmail.com
Subject: RE: [PATCH] wrapper: remove xunsetenv()
Date: Fri, 29 Oct 2021 20:13:28 -0400 [thread overview]
Message-ID: <015d01d7cd22$fa6c6970$ef453c50$@nexbridge.com> (raw)
In-Reply-To: <xmqq35ojihx7.fsf@gitster.g>
On October 29, 2021 6:29 PM, Junio C Hamano wrote:
> <rsbecker@nexbridge.com> writes:
>
> > On October 29, 2021 5:59 PM, Junio C Hamano wrote:
> >> Jeff King <peff@peff.net> writes:
> >>
> >> > However, according to the unsetenv() manpage:
> >> >
> >> > Prior to glibc 2.2.2, unsetenv() was prototyped as returning void;
> >> > more recent glibc versions follow the POSIX.1-compliant prototype
> >> > shown in the SYNOPSIS.
> >> >
> >> > So it is POSIX to return an int, but that gives us at least one
> >> > platform where unsetenv() returns void (or used to). glibc 2.2.2 is
> >> > 2001-era, so that may be old enough that we don't care. But it
> >> > makes me wonder if other older or obscure platforms will run into this.
> >>
> >> Ahh, OK. Well, we will hear from them soon enough. It is not like
> >> this is anything urgent.
> >
> > Well... maybe for some of us 😉
>
> Heh, but we all know you are capable of locally patching ;-).
Our CI/CD uses Jenkins and depends directly on the git repo, like normal people 😉
next prev parent reply other threads:[~2021-10-30 0:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <013a01d7cd092d91cb088b5610nexbridge.com>
2021-10-29 21:27 ` [PATCH] wrapper: remove xunsetenv() Carlo Marcelo Arenas Belón
2021-10-29 21:37 ` Jeff King
2021-10-29 21:43 ` rsbecker
2021-10-29 21:50 ` Carlo Arenas
2021-10-29 21:56 ` Junio C Hamano
2021-10-29 21:51 ` Jeff King
2021-10-29 21:58 ` Junio C Hamano
2021-10-29 22:00 ` Jeff King
2021-10-29 22:03 ` Junio C Hamano
2021-10-29 23:11 ` Jeff King
2021-10-29 22:01 ` rsbecker
2021-10-29 22:29 ` Junio C Hamano
2021-10-30 0:13 ` rsbecker [this message]
2021-10-29 21:37 ` rsbecker
2021-10-29 21:43 ` Carlo Arenas
2021-10-29 21:48 ` rsbecker
2021-10-29 21:53 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='015d01d7cd22$fa6c6970$ef453c50$@nexbridge.com' \
--to=rsbecker@nexbridge.com \
--cc=avarab@gmail.com \
--cc=carenas@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).