From: <rsbecker@nexbridge.com>
To: "'Junio C Hamano'" <gitster@pobox.com>,
"'Patrick Steinhardt'" <ps@pks.im>
Cc: "'Jeff King'" <peff@peff.net>, <git@vger.kernel.org>
Subject: RE: [Change] Git build issue on NonStop
Date: Thu, 18 Sep 2025 11:20:15 -0400 [thread overview]
Message-ID: <020001dc28af$bfec1420$3fc43c60$@nexbridge.com> (raw)
In-Reply-To: <xmqqbjn7akca.fsf@gitster.g>
On September 18, 2025 10:48 AM, Junio C Hamano wrote:
>Patrick Steinhardt <ps@pks.im> writes:
>
>> One thing I missed: `uintmax_t` doesn't work on 32 bit systems:
>>
>> ::error file=clar.c,line=879::clar.c:879:8: cast from pointer to
integer of different
>size [-Werror=pointer-to-int-cast]
>> 879 | (uintmax_t)p1, (uintmax_t)p2);
>> | ^
>>
>> I'm inclined to just use "%p" instead and accept that this has
>> platform-dependent behaviour. Means we'll have to drop the test for
>> this, but that's the lesser evil from my point of view.
>
>As long as %p works everywhere and with stable output, that is the most
>appropriate solution, I would think. After all, this is used only for
"oops, the test
>expects these two pointers are pointing at the same address, but they
differ; they
>point at these places...".
>
>To test such a test, wouldn't it be sufficient to perform "does it give a
bit of output
>or not?" check in isolation?
Surprisingly, this actually works on NonStop x86 in both memory models
despite
warnings to the contrary in their man page.. Thanks :)
prev parent reply other threads:[~2025-09-18 15:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-18 2:16 [Change] Git build issue on NonStop rsbecker
2025-09-18 2:29 ` Jeff King
2025-09-18 3:20 ` rsbecker
2025-09-18 5:37 ` Patrick Steinhardt
2025-09-18 6:31 ` Jeff King
2025-09-18 13:00 ` Patrick Steinhardt
2025-09-18 14:47 ` Junio C Hamano
2025-09-18 15:20 ` rsbecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='020001dc28af$bfec1420$3fc43c60$@nexbridge.com' \
--to=rsbecker@nexbridge.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).