From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from secure.elehost.com (secure.elehost.com [185.209.179.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5EADD189B98 for ; Thu, 1 Aug 2024 13:47:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.209.179.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722520079; cv=none; b=mvRre4Fmq94urX+dF5sTSk72uO1Bjw14nzYkEyvdU3bRYHOe27ruAIPgzCQCPyucdWdxK6QlYyhLRvHSwl1dMHruAL1ozV2k45sPCGhUd0EPNEhweQ124agm9v+muIudXIN+isppcEQl1EdsNaiCAtZcvrUHfum7R1Jswu0HyOs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722520079; c=relaxed/simple; bh=wfe/g57ThQOPIRWMRhxMpzbLYcKLP7z80OkKv6BFvk0=; h=From:To:Cc:References:In-Reply-To:Subject:Date:Message-ID: MIME-Version:Content-Type; b=RdDcAzGYefdkkYthG4l3eW/Re7Z1XQI1TkDUz1adMylxScGn+cqO82ixbkjW03sp5IcCF63BC8LhYG3asQJlwFKfl0wLmuPr085ttq0jdrZBcCktbJ+YW0z7PBe51FgGo5ZczzVemNzejLEFGb/uTwLeuAio54TEn15HN9fdsS4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nexbridge.com; spf=pass smtp.mailfrom=nexbridge.com; arc=none smtp.client-ip=185.209.179.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nexbridge.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nexbridge.com X-Virus-Scanned: Debian amavisd-new at secure.elehost.com Received: from Mazikeen (pool-99-228-12-196.cpe.net.cable.rogers.com [99.228.12.196]) (authenticated bits=0) by secure.elehost.com (8.15.2/8.15.2/Debian-22ubuntu3) with ESMTPSA id 471DlhTZ3444153 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 1 Aug 2024 13:47:44 GMT Reply-To: From: To: "'Patrick Steinhardt'" Cc: "'Josh Steadmon'" , , "=?iso-8859-1?Q?'Ren=E9_Scharfe'?=" , "'Junio C Hamano'" , "'Kyle Lippincott'" , "'Phillip Wood'" References: <463oz7j4btei57brq42zlnsydguu74n2n22rhdq7iwjk4y2bei@6r32nghurrmr> <00a801dae384$de2780d0$9a768270$@nexbridge.com> <01c201dae40c$821ab5e0$865021a0$@nexbridge.com> <024601dae411$faab2cb0$f0018610$@nexbridge.com> In-Reply-To: Subject: RE: [RFC PATCH 1/3] t: import the clar unit testing framework Date: Thu, 1 Aug 2024 09:47:38 -0400 Organization: Nexbridge Inc. Message-ID: <025f01dae419$636bb790$2a4326b0$@nexbridge.com> Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Content-Language: en-ca Thread-Index: AQE2Q9x0fuag13GoRDOLG7kBaq5wcQE8qfSQAlNXoAsBzj75QwLkmT4KAVwZTGUB2+aESgLXgUnWsukX4JA= On Thursday, August 1, 2024 9:37 AM, Patrick Steinhardt wrote: >On Thu, Aug 01, 2024 at 08:54:36AM -0400, rsbecker@nexbridge.com wrote: >> On Thursday, August 1, 2024 8:15 AM, I wrote: >> >On Thursday, August 1, 2024 5:32 AM, Patrick Steinhardt wrote: >> >>On Wed, Jul 31, 2024 at 04:04:29PM -0400, rsbecker@nexbridge.com wrote: >> >>> On Wednesday, July 31, 2024 2:27 PM, Josh Steadmon wrote: >> >>> >On 2024.07.31 11:04, Patrick Steinhardt wrote: >> >>> >> Import the clar unit testing framework at commit faa8419 (Merge >> >>> >> pull request #93 from clar-test/ethomson/fixtures, 2023-12-14). >> >>> >> The framework will be wired up in subsequent commits. >> >>> > >> >>> >Rather than forking our own copy of clar, could we just add it as >> >>> >a >> >>> submodule >> >>> >instead? >> >>> >> >>> What are the requirements to build/use this? >> >> >> >>In its current form, Python is a dependency due to "generate.py". I >> >mentioned >> >>elsewhere though that I'd be happy to port it to our language of choice. >> >> >> >>Other than that it should only require a C89 compiler. >> > >> >Unfortunately, it needs gcc, but that is just because of its Makefile >> >using >> cc -Wall >> >(not portable). >> >> It looks like clar needs CC=c99 when running generate.py, which is >> fine. But there is no current way to suppress -Wall without >> hand-modifying clar/test/Makefile. The options like that should either >> be in CFLAGS?=... instead of CFLAGS=... or we could introduce >> CFLAGS_DBG?= and put -Wall in there - it is only for reporting >> warnings which is done different in the c99 I have. >> Ideally, the CFLAGS should come >> from ./git/config.mak.uname/ > >As mentioned in another mail, we do not use its Makefile at all. Did you check >whether the version I have proposed here works when running `make test`? That is the commit I have been trying to use. make test in clar or git?