From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from secure.elehost.com (secure.elehost.com [185.209.179.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 53D8C61FF2 for ; Thu, 1 Aug 2024 14:04:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.209.179.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722521095; cv=none; b=U0osp9IIJOTRaH9MG1StB7oig+q/jTGDryRf5bWw/sUfELUFu5C6zYnSXfUUW1YBgZJ5DlrOnu566AuokLfapaEbFrz7DigupEwk1zXMDoGjD1v/ngP/pit6aIAJO/EdyrCmALXfLDiv7cnALsqsgIebjh7SO6LLss5ZfSsyxhw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722521095; c=relaxed/simple; bh=fUE0rFDvsLfVbiEL3dpRcIai0UuevK8YCCrNIUjqqd0=; h=From:To:Cc:References:In-Reply-To:Subject:Date:Message-ID: MIME-Version:Content-Type; b=hE3gIkf00b/PpNbvMN10HGze0ONqbhjLMIIT4Da9DxEvXK6jrUXJClyrRFZWQ9Cskq4f5/GPXIHvKRJDgWFqRmN8HA6fcaYgy5sS5WcvSJkQmu2saSyZkBPiSyFhK10nzKDrlAhH5/SgCfIVT3YssH6rZHPBfBhKkj1M6KM48p4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nexbridge.com; spf=pass smtp.mailfrom=nexbridge.com; arc=none smtp.client-ip=185.209.179.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nexbridge.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nexbridge.com X-Virus-Scanned: Debian amavisd-new at secure.elehost.com Received: from Mazikeen (pool-99-228-12-196.cpe.net.cable.rogers.com [99.228.12.196]) (authenticated bits=0) by secure.elehost.com (8.15.2/8.15.2/Debian-22ubuntu3) with ESMTPSA id 471E4guY3448201 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 1 Aug 2024 14:04:43 GMT Reply-To: From: To: "'Patrick Steinhardt'" Cc: "'Josh Steadmon'" , , "=?iso-8859-1?Q?'Ren=E9_Scharfe'?=" , "'Junio C Hamano'" , "'Kyle Lippincott'" , "'Phillip Wood'" References: <463oz7j4btei57brq42zlnsydguu74n2n22rhdq7iwjk4y2bei@6r32nghurrmr> <00a801dae384$de2780d0$9a768270$@nexbridge.com> <01c201dae40c$821ab5e0$865021a0$@nexbridge.com> <024601dae411$faab2cb0$f0018610$@nexbridge.com> <025f01dae419$636bb790$2a4326b0$@nexbridge.com> <027301dae41a$41ea7ce0$c5bf76a0$@nexbridge.com> In-Reply-To: Subject: RE: [RFC PATCH 1/3] t: import the clar unit testing framework Date: Thu, 1 Aug 2024 10:04:37 -0400 Organization: Nexbridge Inc. Message-ID: <028501dae41b$c277ec20$4767c460$@nexbridge.com> Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Content-Language: en-ca Thread-Index: AQE8qfSQEsvy7NtGQBhHu5xmF2sogwJTV6ALAc4++UMC5Jk+CgFcGUxlAdvmhEoC14FJ1gGACBcdAf7OY6EBgcHASgEQLlLbsrWvq4A= On Thursday, August 1, 2024 9:55 AM, Patrick Steinhardt wrote: >On Thu, Aug 01, 2024 at 09:53:52AM -0400, rsbecker@nexbridge.com wrote: >> On Thursday, August 1, 2024 9:50 AM, Patrick Steinhardt wrote: >> >On Thu, Aug 01, 2024 at 09:47:38AM -0400, rsbecker@nexbridge.com wrote: >> >> On Thursday, August 1, 2024 9:37 AM, Patrick Steinhardt wrote: >> >> >As mentioned in another mail, we do not use its Makefile at all. >> >> >Did you >> >> check >> >> >whether the version I have proposed here works when running `make test`? >> >> >> >> That is the commit I have been trying to use. make test in clar or git? >> > >> >In Git itself. `make test` builds and runs our unit tests, and that >> >now >> also includes >> >unit tests based on clar with this patch series. The clar Makefile >> >exists >> only because I >> >did a 1:1 import of the upstream dependency. We could just as well >> >remove >> it >> >altogether, including other bits that we don't end up using. >> >> I see. Well, the 2.46.0 test passes. I ran 'seen' 5 days ago and >> 'next' is going now. Would that catch it? > >No, as the patches in this thread are only up for discussion right now and have not >been merged to any of the branches. You'd have to apply them on top of v2.46.0 >first :) Do you happen to have a public fork? Regards, Randall