From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <git-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 8503DCD484C
	for <git@archiver.kernel.org>; Fri, 22 Sep 2023 18:50:15 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S233167AbjIVSuT convert rfc822-to-8bit (ORCPT
        <rfc822;git@archiver.kernel.org>); Fri, 22 Sep 2023 14:50:19 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36878 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229526AbjIVSuS (ORCPT <rfc822;git@vger.kernel.org>);
        Fri, 22 Sep 2023 14:50:18 -0400
Received: from secure.elehost.com (secure.elehost.com [185.209.179.11])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 873E7AB
        for <git@vger.kernel.org>; Fri, 22 Sep 2023 11:50:10 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at secure.elehost.com
Received: from Mazikeen (cpebc4dfb928313-cmbc4dfb928310.cpe.net.cable.rogers.com [99.228.251.108] (may be forged))
        (authenticated bits=0)
        by secure.elehost.com (8.15.2/8.15.2/Debian-22ubuntu3) with ESMTPSA id 38MIlLcK1908586
        (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
        Fri, 22 Sep 2023 18:47:22 GMT
Reply-To: <rsbecker@nexbridge.com>
From:   <rsbecker@nexbridge.com>
To:     "'Ben Boeckel'" <ben.boeckel@kitware.com>
Cc:     "'Junio C Hamano'" <gitster@pobox.com>, <git@vger.kernel.org>
References: <ZNffWAgldUZdpQcr@farprobe> <ZQ21NsLmp+xQU5g+@farprobe> <02d701d9ed6f$abcb4b00$0361e100$@nexbridge.com> <ZQ3GAJ/AHsM9e9a6@farprobe> <02e701d9ed78$436b3c60$ca41b520$@nexbridge.com> <xmqqediq2j0g.fsf@gitster.g> <032d01d9ed80$5e569670$1b03c350$@nexbridge.com> <ZQ3ggxA7KOysXrba@farprobe>
In-Reply-To: <ZQ3ggxA7KOysXrba@farprobe>
Subject: RE: [BUG] `git describe` doesn't traverse the graph in topological order
Date:   Fri, 22 Sep 2023 14:49:58 -0400
Organization: Nexbridge Inc.
Message-ID: <033201d9ed85$991c6af0$cb5540d0$@nexbridge.com>
MIME-Version: 1.0
Content-Type: text/plain;
        charset="utf-8"
Content-Transfer-Encoding: 8BIT
X-Mailer: Microsoft Outlook 16.0
Content-Language: en-ca
Thread-Index: AQMniK2C5ueFGaecrAkj2WziqqcqsgIDXfPaAV8c8ysBL0/7iQKiZtYXAnm84MABE+XlegDThaDjrS9OjIA=
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org

On Friday, September 22, 2023 2:44 PM, Ben Boeckel wrote:
>On Fri, Sep 22, 2023 at 14:12:31 -0400, rsbecker@nexbridge.com wrote:
>> What confuses me is how, in the other subthread, that adding sleep 1
>> to the construction of history should make any difference. My
>> understanding is that the path to the tag is invariant of the commit-date.
>
>Yes. It is explained that the commit date stored is only to 1 second granularity. Since
>the commits are stored in commit-date, an equal commit date ends up "twisting" the
>history and traversing some ancestors of commits before the commits themsevles.
>This loses the "seen" bit tracking that is done and ends up labeling way more
>commits as "not part of" ancestors. By sleeping for a second, the commit dates can
>be totally ordered reliably.

This is going to be awkward to resolve as time_t only resolves (portably) to 1 second intervals. I still would prefer the resolution to be path-based rather than time-based.