From: Joerg Bornemann <git@jbornemann.de>
To: git@vger.kernel.org
Subject: [PATCH (GIT-GUI BUG)] git-gui: use of undeclared variable in handle_empty_diff
Date: Sun, 05 Apr 2009 22:20:14 +0200 [thread overview]
Message-ID: <0337ff5648e5e0dc583e255a44573dbf@mb8-2.1blu.de> (raw)
[-- Attachment #1: Type: text/plain, Size: 381 bytes --]
Commit 584fa9cc ("git-gui: Avoid an infinite rescan loop in
handle_empty_diff.") introduced the global variable diff_empty_count, which
is used in diff.tcl. But this variable isn't declared anywhere which
results in an ugly error message box instead of the intended informative
message. This patch fixes this and removes the unnecessary second
initialization of current_diff_path.
[-- Attachment #2: diff.txt --]
[-- Type: text/plain, Size: 442 bytes --]
diff --git a/git-gui.sh b/git-gui.sh
index b3aa732..b0d5028 100755
--- a/git-gui.sh
+++ b/git-gui.sh
@@ -1104,10 +1104,10 @@ set commit_type {}
set empty_tree {}
set current_branch {}
set is_detached 0
-set current_diff_path {}
set is_3way_diff 0
set is_conflict_diff 0
set selected_commit_type new
+set diff_empty_count 0
set nullid "0000000000000000000000000000000000000000"
set nullid2 "0000000000000000000000000000000000000001"
next reply other threads:[~2009-04-05 21:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-05 20:20 Joerg Bornemann [this message]
2009-04-05 21:20 ` [PATCH (GIT-GUI BUG)] git-gui: use of undeclared variable in handle_empty_diff Sverre Rabbelier
2009-04-05 21:35 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0337ff5648e5e0dc583e255a44573dbf@mb8-2.1blu.de \
--to=git@jbornemann.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox