From: Phillip Wood <phillip.wood123@gmail.com>
To: Patrick Steinhardt <ps@pks.im>, Stefan Haller <lists@haller-berlin.de>
Cc: phillip.wood@dunelm.org.uk, git@vger.kernel.org
Subject: Re: Interactive rebase: using "pick" for merge commits
Date: Mon, 12 Feb 2024 14:38:08 +0000 [thread overview]
Message-ID: <040f142c-7ee2-429e-88eb-d328b01a4b8c@gmail.com> (raw)
In-Reply-To: <ZcnFl8kypKRYeLo3@tanuki>
Hi Patrick and Stefan
On 12/02/2024 07:15, Patrick Steinhardt wrote:
> On Sat, Feb 10, 2024 at 10:23:16AM +0100, Stefan Haller wrote:
>> On 09.02.24 17:24, Phillip Wood wrote:
>> Yes, I'm familiar with all this, but that's not what I mean. I don't
>> want to maintain the topology here, and I'm also not suggesting that git
>> itself generates such "pick" entries with -mX arguments (maybe I wasn't
>> clear on that). What I want to do is to add such entries myself, as a
>> user, resulting in the equivalent of doing a "break" at that point in
>> the rebase and doing a "git cherry-pick -mX <hash-of-merge-commit>"
>> manually.
>
> It would be neat indeed if this could be specified in the instruction
> sheet. We already support options for the "merge" instruction, so
> extending "pick" to support options isn't that far-fetched. Then it
> would become possible to say "pick -m1 fa1afe1".
It would certainly be possible to extend the sequencer to do that but
I'm not familiar with why people use "git cherry-pick -m" [1] so I'm
wondering what this would be used for. It would involve a bit of extra
complexity so I think we'd want a compelling reason as to why
cherry-picking merges without maintaining the topology is useful
especially as one can currently do that via "exec git cherry-pick -m ..."
Best Wishes
Phillip
[1] I did a quick web search and the results all seemed to focus on how
to do it rather than why you'd want to.
next prev parent reply other threads:[~2024-02-12 14:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-09 15:52 Interactive rebase: using "pick" for merge commits Stefan Haller
2024-02-09 16:24 ` Phillip Wood
2024-02-10 9:23 ` Stefan Haller
2024-02-12 7:15 ` Patrick Steinhardt
2024-02-12 14:38 ` Phillip Wood [this message]
2024-02-23 20:59 ` Stefan Haller
2024-02-26 10:56 ` Phillip Wood
2024-02-26 19:07 ` Stefan Haller
2024-02-27 10:41 ` phillip.wood123
2024-02-12 16:39 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=040f142c-7ee2-429e-88eb-d328b01a4b8c@gmail.com \
--to=phillip.wood123@gmail.com \
--cc=git@vger.kernel.org \
--cc=lists@haller-berlin.de \
--cc=phillip.wood@dunelm.org.uk \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).