From: "René Scharfe" <l.s.r@web.de>
To: "Burak Kaan Karaçay" <bkkaracay@gmail.com>, git@vger.kernel.org
Cc: christian.couder@gmail.com, karthik.188@gmail.com,
jltobler@gmail.com, ayu.chandekar@gmail.com,
siddharthasthana31@gmail.com, ps@pks.im
Subject: Re: [PATCH 0/4] wean start_command() off the_repository
Date: Wed, 11 Mar 2026 19:18:10 +0100 [thread overview]
Message-ID: <041604ef-0bdb-4c40-a9e1-60c38ae664cb@web.de> (raw)
In-Reply-To: <20260311151923.4178655-1-bkkaracay@gmail.com>
On 3/11/26 4:19 PM, Burak Kaan Karaçay wrote:
>
> start_command() relies on the_repository due to the 'close_object_store'
> flag in 'struct child_process'. Introduce repo_start_command() to allow
> working with arbitrary repositories. Turn start_command() into a macro
> that wraps repo_start_command() and migrate the existing callers with a
> cocci script.
Good idea to expose this hidden dependency. It's different from the
other repo_* functions, though, in that most callers can safely pass
NULL as repo because they don't set close_object_store.
Only gc, pull and auto-maintenance set close_object_store. If we
changed them to set a pointer to the object store they want to have
closed instead of a binary flag then we could leave the other callers
unchanged.
René
next prev parent reply other threads:[~2026-03-11 18:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-11 15:19 [PATCH 0/4] wean start_command() off the_repository Burak Kaan Karaçay
2026-03-11 15:19 ` [PATCH 1/4] run-command: add repo_start_command() Burak Kaan Karaçay
2026-03-11 15:19 ` [PATCH 2/4] run-command: use repo_start_command() in strict callers Burak Kaan Karaçay
2026-03-11 19:26 ` Junio C Hamano
2026-03-11 15:19 ` [PATCH 3/4] run-command: redefine start_command() as a wrapper macro Burak Kaan Karaçay
2026-03-11 15:19 ` [PATCH 4/4] cocci: convert start_command() to repo_start_command() Burak Kaan Karaçay
2026-03-11 18:18 ` René Scharfe [this message]
2026-03-11 18:45 ` [PATCH 0/4] wean start_command() off the_repository Jeff King
2026-03-11 19:09 ` Burak Kaan Karaçay
2026-03-11 19:35 ` Junio C Hamano
2026-03-11 19:30 ` Junio C Hamano
2026-03-12 8:53 ` [PATCH v2] run-command: " Burak Kaan Karaçay
2026-03-12 10:01 ` Patrick Steinhardt
2026-03-12 14:44 ` [PATCH v3 0/2] run-command: stop using the_repository Burak Kaan Karaçay
2026-03-12 14:44 ` [PATCH v3 1/2] run-command: wean start_command() off the_repository Burak Kaan Karaçay
2026-03-12 14:44 ` [PATCH v3 2/2] run-command: wean auto_maintenance() functions " Burak Kaan Karaçay
2026-03-12 15:29 ` [PATCH v3 0/2] run-command: stop using the_repository Junio C Hamano
2026-03-13 6:23 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=041604ef-0bdb-4c40-a9e1-60c38ae664cb@web.de \
--to=l.s.r@web.de \
--cc=ayu.chandekar@gmail.com \
--cc=bkkaracay@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=jltobler@gmail.com \
--cc=karthik.188@gmail.com \
--cc=ps@pks.im \
--cc=siddharthasthana31@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox