public inbox for git@vger.kernel.org
 help / color / mirror / Atom feed
From: Derrick Stolee <stolee@gmail.com>
To: Patrick Steinhardt <ps@pks.im>, Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] commit-graph: fix writing generations with dates exceeding 34 bits
Date: Fri, 20 Mar 2026 13:21:50 -0400	[thread overview]
Message-ID: <0566e178-4f12-4647-a257-29631a769b49@gmail.com> (raw)
In-Reply-To: <abueHjVHCztQtL6b@pks.im>

On 3/19/2026 2:56 AM, Patrick Steinhardt wrote:
> On Tue, Mar 17, 2026 at 12:39:39PM -0700, Junio C Hamano wrote:
>> Patrick Steinhardt <ps@pks.im> writes:
>>
>>> this fixes a regression recently introduced by myself in 024b4c9697
>>> (commit: make `repo_parse_commit_no_graph()` more robust, 2026-02-16).
>>> The regression was found by GitLab's tests suite, see [1].
>>
>> Curious.  GitLab's test suite runs pretending that it is way past
>> year 2600 or something?  
> 
> No, but one of the test repositories that we're running tests with [1]
> contains such a commit.
> 
> Patrick
> 
> [1]: https://gitlab.com/gitlab-org/gitlab-test
 
I'm glad you have this test! Thanks for bringing such a data shape
into the Git test suite with this change so we can correct problems
this way in our inner loop testing.

I agree with Junio that the code looks good.

Thanks,
-Stolee


  reply	other threads:[~2026-03-20 17:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-17 19:02 [PATCH] commit-graph: fix writing generations with dates exceeding 34 bits Patrick Steinhardt
2026-03-17 19:39 ` Junio C Hamano
2026-03-19  6:56   ` Patrick Steinhardt
2026-03-20 17:21     ` Derrick Stolee [this message]
2026-03-24  6:18 ` [PATCH v2] " Patrick Steinhardt
2026-03-24 15:42   ` Junio C Hamano
2026-03-25  5:36     ` Patrick Steinhardt
2026-03-26 10:02   ` Karthik Nayak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0566e178-4f12-4647-a257-29631a769b49@gmail.com \
    --to=stolee@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox