From: Derrick Stolee <stolee@gmail.com>
To: Stefan Beller <sbeller@google.com>,
Derrick Stolee <dstolee@microsoft.com>
Cc: git <git@vger.kernel.org>
Subject: Re: [PATCH 7/9] treewide: use get_all_packs
Date: Tue, 21 Aug 2018 09:56:42 -0400 [thread overview]
Message-ID: <05f42490-bf11-8673-61db-e0afd04af43a@gmail.com> (raw)
In-Reply-To: <CAGZ79kZFXof091d4qXUVyLJ9wGPL0sfs9XruZ-3Hjoq74-tjCg@mail.gmail.com>
On 8/20/2018 6:01 PM, Stefan Beller wrote:
> On Mon, Aug 20, 2018 at 9:52 AM Derrick Stolee <dstolee@microsoft.com> wrote:
>> There are many places in the codebase that want to iterate over
>> all packfiles known to Git. The purposes are wide-ranging, and
>> those that can take advantage of the multi-pack-index already
>> do. So, use get_all_packs() instead of get_packed_git() to be
>> sure we are iterating over all packfiles.
> So get_packed_git shouold not be used any further?
> Do we want to annotate it as deprecated, to be deleted
> in the future? Or even remove it as part of this series
> (that might be an issue with other series in flight).
Perhaps the right thing to do would be to put a big warning over the
definition to say "only use this if you really don't want
get_all_packs()" or something. The reason I didn't remove it from
packfile.h is that it is used in sha1-name.c alongside
get_multi_pack_index() (so making it 'static' would be incorrect).
next prev parent reply other threads:[~2018-08-21 13:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-20 16:51 [PATCH 0/9] multi-pack-index cleanups Derrick Stolee
2018-08-20 16:51 ` [PATCH 1/9] multi-pack-index: provide more helpful usage info Derrick Stolee
2018-08-20 16:51 ` [PATCH 2/9] multi-pack-index: store local property Derrick Stolee
2018-08-20 21:14 ` Stefan Beller
2018-08-20 16:51 ` [PATCH 3/9] midx: mark bad packed objects Derrick Stolee
2018-08-20 21:23 ` Stefan Beller
2018-08-21 13:53 ` Derrick Stolee
2018-08-20 16:51 ` [PATCH 4/9] midx: stop reporting garbage Derrick Stolee
2018-08-20 16:52 ` [PATCH 5/9] midx: fix bug that skips midx with alternates Derrick Stolee
2018-08-20 16:52 ` [PATCH 6/9] packfile: add all_packs list Derrick Stolee
2018-08-20 16:52 ` [PATCH 7/9] treewide: use get_all_packs Derrick Stolee
2018-08-20 22:01 ` Stefan Beller
2018-08-21 13:56 ` Derrick Stolee [this message]
2018-08-20 16:52 ` [PATCH 8/9] midx: test a few commands that " Derrick Stolee
2018-08-20 22:03 ` Stefan Beller
2018-08-20 16:52 ` [PATCH 9/9] pack-objects: consider packs in multi-pack-index Derrick Stolee
2018-08-21 14:34 ` [PATCH 0/9] multi-pack-index cleanups Duy Nguyen
2018-08-21 14:44 ` Derrick Stolee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05f42490-bf11-8673-61db-e0afd04af43a@gmail.com \
--to=stolee@gmail.com \
--cc=dstolee@microsoft.com \
--cc=git@vger.kernel.org \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).