From: Andreas Heiduk <asheiduk@gmail.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Adam Dinwoodie <adam@dinwoodie.org>, git@vger.kernel.org
Subject: Re: [PATCH] doc: correct command formatting
Date: Fri, 29 Sep 2017 00:28:21 +0200 [thread overview]
Message-ID: <0635cfc6-e5ce-c0eb-d0e4-636fb57fbe4f@gmail.com> (raw)
In-Reply-To: <20170928193412.GB174074@aiede.mtv.corp.google.com>
Am 28.09.2017 um 21:34 schrieb Jonathan Nieder:
> Andreas Heiduk wrote:
>
>> +1, Thanks for spotting.
>
> Thanks for looking it over. Can we add your Reviewed-by? (See [1]
> for what this means.)
Well, I'd like to see the following occurrence of the same problem
solved in that patch, too. Beyond that - your welcome.
>>
>> Documentation/git-format-patch.txt: `--subject-prefix` option) has ` v<n>` appended to it. E.g.
>>
>> But here the space IS relevant but asciidoc does not pick up
>> the formatting. Perhaps that one could read like this:
>>
>> `--subject-prefix` option) has `<SPACE>v<n>` appended to it. E.g.
...
> In some output formats, the text with backticks surrounding it is
> shown in a different background color, which makes something like
> `{space}v<n>` tempting (with appropriate definition of {space} in
> the attributes section of asciidoc.conf). But that feels way too
> subtle.
>
> How about something like
>
> has a space and `v<n>` appended to it
Well, in the original text "<n>" is already used as a replacement
marker. Therefore "<space>" seemed obvious to me as another replacement
marker which avoids exactly that problem.
>
> ?
>
> Thanks,
> Jonathan
>
> [1] https://kernel.googlesource.com/pub/scm/linux/kernel/git/torvalds/linux/+/9cd6681cb1169e815c41af0265165dd1b872f228/Documentation/process/submitting-patches.rst#563
>
next prev parent reply other threads:[~2017-09-28 22:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-28 14:06 [PATCH] doc: correct command formatting Adam Dinwoodie
2017-09-28 17:18 ` Andreas Heiduk
2017-09-28 19:34 ` Jonathan Nieder
2017-09-28 22:28 ` Andreas Heiduk [this message]
2017-09-29 1:53 ` Junio C Hamano
2017-09-29 3:27 ` Jonathan Nieder
2017-09-29 4:07 ` Junio C Hamano
2017-09-28 19:03 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0635cfc6-e5ce-c0eb-d0e4-636fb57fbe4f@gmail.com \
--to=asheiduk@gmail.com \
--cc=adam@dinwoodie.org \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).