From: Antonio Russo <antonio.e.russo@gmail.com>
To: Derrick Stolee <stolee@gmail.com>, git-ml <git@vger.kernel.org>
Subject: Re: [PATCH] Teach git-rev-list --simplify-forks
Date: Tue, 28 Apr 2020 06:49:00 -0600 [thread overview]
Message-ID: <070c07f6-5b36-89e7-a9fe-9bd321fcb97e@gmail.com> (raw)
In-Reply-To: <4ee983f6-402f-85bb-25a8-75b39f07cabb@gmail.com>
On 4/27/20 4:55 AM, Derrick Stolee wrote:
>
> This is probably because the tests run a second round with GIT_TEST_COMMIT_GRAPH=1, which enables the commit-graph feature. This triggers a different set of logic for the topo-order, which ignores the logic the way you inserted it here.
>
Thank you for pointing me at this. If I now understand correctly, the commit information
is not yet necessarily loaded for all commits at this point, and therefore the logic here
will need to be called later on (and makes it more complicated).
Am I correct that this loading of parents happens during traverse_commit_list_filtered
(for the case of rev-list)? Also, am I correct that there are not yet any hooks to
filter out edges (of the graph of commits)?
Thank you,
Antonio
next prev parent reply other threads:[~2020-04-28 12:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 5:07 [PATCH] Teach git-rev-list --simplify-forks Antonio Russo
2020-04-27 10:55 ` Derrick Stolee
2020-04-28 12:49 ` Antonio Russo [this message]
2020-04-28 14:11 ` Derrick Stolee
2020-04-29 8:01 ` [PATCH v2] " Antonio Russo
2020-04-29 10:08 ` Philip Oakley
2020-04-29 13:04 ` Antonio Russo
2020-04-29 13:12 ` Derrick Stolee
2020-05-01 14:13 ` Antonio Russo
2020-05-01 15:44 ` Derrick Stolee
2020-05-01 14:21 ` [PATCH 1/3 v3] Clean up t6016-rev-list-graph-simplify-history Antonio Russo
2020-05-01 17:10 ` Junio C Hamano
2020-05-02 15:27 ` Antonio Russo
2020-05-01 14:22 ` [PATCH 2/3 v3] Teach git-rev-list --ignore-merge-bases Antonio Russo
2020-05-02 13:25 ` Johannes Sixt
2020-05-02 14:21 ` Antonio Russo
2020-05-01 14:23 ` [PATCH 3/3 v3] Add new tests of ignore-merge-bases Antonio Russo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=070c07f6-5b36-89e7-a9fe-9bd321fcb97e@gmail.com \
--to=antonio.e.russo@gmail.com \
--cc=git@vger.kernel.org \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).