From: Peter TB Brett <peter@peter-b.co.uk>
To: "David Kågedal" <davidk@lysator.liu.se>
Cc: <git@vger.kernel.org>
Subject: [stgit PATCH] stgit.el: Stop "Summary:" being added to all commit msgs.
Date: Mon, 13 Jun 2011 09:37:26 +0100 [thread overview]
Message-ID: <077cac32c74edaff2f20c84897bfc171@mail.theimps.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 522 bytes --]
In Emacs 23.3.1, if `log-edit' is called with a non-nil `setup' argument,
it unconditionally appends "Summary:" to the log buffer. It causes great
annoyance to have to remember to find and delete this string on every patch
commit message edit with stgit-mode. This patch makes `stgit-edit' call
`log-edit' with a nil `setup' argument.
Did I mention that this is *incredibly annoying*?
See also https://gna.org/bugs/?18206
Peter
--
Peter Brett <peter@peter-b.co.uk>
Remote Sensing Research Group
Surrey Space Centre
[-- Attachment #2: 0001-stgit.el-Stop-Summary-being-added-to-all-commit-msgs.patch --]
[-- Type: text/plain, Size: 1296 bytes --]
From 4cdf9770144933c5cd2b0399cc084841c1d5c46d Mon Sep 17 00:00:00 2001
From: Peter TB Brett <peter@peter-b.co.uk>
Date: Mon, 13 Jun 2011 09:33:12 +0100
Subject: [PATCH] stgit.el: Stop "Summary:" being added to all commit msgs.
In Emacs 23.3.1, if `log-edit' is called with a non-nil `setup'
argument, it unconditionally appends "Summary:" to the log buffer. It
causes great annoyance to have to remember to find and delete this
string on every patch commit message edit with stgit-mode. This patch
makes `stgit-edit' call `log-edit' with a nil `setup' argument.
Signed-off-by: Peter TB Brett <peter@peter-b.co.uk>
---
contrib/stgit.el | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/contrib/stgit.el b/contrib/stgit.el
index c71df4b..f640e5e 100644
--- a/contrib/stgit.el
+++ b/contrib/stgit.el
@@ -2298,7 +2298,7 @@ file ended up. You can then jump to the file with \
(let ((patchsym (stgit-patch-name-at-point t t))
(edit-buf (get-buffer-create "*StGit edit*"))
(dir default-directory))
- (log-edit 'stgit-confirm-edit t nil edit-buf)
+ (log-edit 'stgit-confirm-edit nil nil edit-buf)
(set (make-local-variable 'stgit-edit-patchsym) patchsym)
(setq default-directory dir)
(let ((standard-output edit-buf))
--
1.7.6.rc1
next reply other threads:[~2011-06-13 8:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-13 8:37 Peter TB Brett [this message]
2011-06-13 9:11 ` [stgit PATCH] stgit.el: Stop "Summary:" being added to all commit msgs Gustav Hållberg
2011-06-13 9:44 ` Peter TB Brett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=077cac32c74edaff2f20c84897bfc171@mail.theimps.com \
--to=peter@peter-b.co.uk \
--cc=davidk@lysator.liu.se \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).