git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: punk.lion0906@fastmail.com
To: git@vger.kernel.org
Subject: gitk: regression when opening preferences with `want_ttk=0`
Date: Wed, 21 May 2025 19:55:21 -0700	[thread overview]
Message-ID: <087f6a4d-d276-4f1e-94a4-7423b3387b79@app.fastmail.com> (raw)

This duplicates https://github.com/j6t/gitk/issues/18.

I found a regression in `gitk`'s commit 904b36b. When `gitk` is run with `want_ttk=0`
(AKA "use themed widgets" set to off), I cannot open the settings dialog since that
commit.  It gives the following error in a modal dialog, and then opens a completely empty non-modal dialog where the settings dialog should be:

```
`invalid command name "::combobox"
invalid command name "::combobox"
    while executing
"${NS}::combobox $page.wrapcomment -values {none char word} -state readonly  -textvariable wrapcomment"
    (procedure "prefspage_general" line 43)
    invoked from within
"prefspage_general $notebook"
    (procedure "doprefs" line 27)
    invoked from within
"doprefs"
    (procedure "::tk::mac::ShowPreferences" line 1)
    invoked from within
"::tk::mac::ShowPreferences"`
```

Indeed, 904b36b adds some `::combobox`es.

I tested this on MacOS with Tcl/Tk 8.6, both with Homebrew-installed `gitk` from the `git-gui` 2.49.0 package, and with the master branch of https://github.com/j6t/gitk (commit 9f27318), and with that repo's 904b36b. The parent of 904b36b works fine.

The workaround is to close gitk, and set `want_ttk` to 1 in ~/.config/git/gitk, ~/.gitk, or equivalent. Completely deleting the config file at ~/.config/git/gitk also fixed the problem for me.

       Ilya.

             reply	other threads:[~2025-05-22  2:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-22  2:55 punk.lion0906 [this message]
2025-05-22  3:03 ` gitk: regression when opening preferences with `want_ttk=0` punk.lion0906
2025-05-22 17:10 ` Johannes Sixt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=087f6a4d-d276-4f1e-94a4-7423b3387b79@app.fastmail.com \
    --to=punk.lion0906@fastmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).